Skip to content

Commit acdb705

Browse files
committed
Pin crc-fast to =1.4.0 to reproduce ARM SIGILL bug
1 parent 5e8001f commit acdb705

4 files changed

Lines changed: 17 additions & 18 deletions

File tree

.github/workflows/manual-canary.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,14 +92,18 @@ jobs:
9292
action: generate-aws-sdk-for-canary
9393

9494
canary:
95-
name: Canary
95+
name: Canary (${{ matrix.arch }})
9696
needs:
9797
- generate
9898
- get-pr-info
9999
runs-on: smithy_ubuntu-latest_8-core
100100
permissions:
101101
id-token: write
102102
contents: read
103+
strategy:
104+
fail-fast: false
105+
matrix:
106+
arch: [x86_64, aarch64]
103107
steps:
104108
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
105109
- uses: actions/checkout@v4
@@ -117,4 +121,4 @@ jobs:
117121
uses: ./smithy-rs/.github/actions/docker-build
118122
with:
119123
action: run-canary
120-
action-arguments: ${{ secrets.CANARY_STACK_CDK_OUTPUTS_BUCKET_NAME }} ${{ steps.creds.outputs.aws-access-key-id }} ${{ steps.creds.outputs.aws-secret-access-key }} ${{ steps.creds.outputs.aws-session-token }}
124+
action-arguments: ${{ secrets.CANARY_STACK_CDK_OUTPUTS_BUCKET_NAME }} ${{ steps.creds.outputs.aws-access-key-id }} ${{ steps.creds.outputs.aws-secret-access-key }} ${{ steps.creds.outputs.aws-session-token }} ${{ matrix.arch }}

rust-runtime/Cargo.lock

Lines changed: 7 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rust-runtime/aws-smithy-checksums/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "aws-smithy-checksums"
3-
version = "0.63.13"
3+
version = "0.63.14"
44
authors = [
55
"AWS Rust SDK Team <aws-sdk-rust@amazon.com>",
66
"Zelda Hessler <zhessler@amazon.com>",
@@ -18,7 +18,7 @@ aws-smithy-http = { path = "../aws-smithy-http" }
1818
aws-smithy-types = { path = "../aws-smithy-types" }
1919
bytes = "1.10.0"
2020
# FIXME(https://github.com/smithy-lang/smithy-rs/issues/3981): Keep pinned until we have more comprehensive testing in place
21-
crc-fast = "~1.9.0"
21+
crc-fast = "=1.4.0"
2222
hex = "0.4.3"
2323
http = "0.2.9"
2424
http-body = "0.4.5"

tools/ci-cdk/canary-runner/src/build_bundle.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -219,8 +219,7 @@ impl std::str::FromStr for LambdaArchitecture {
219219
"x86_64" | "x86-64" | "amd64" => Ok(LambdaArchitecture::X86_64),
220220
"arm64" | "aarch64" => Ok(LambdaArchitecture::Arm64),
221221
_ => Err(format!(
222-
"Unknown architecture: {}. Use 'x86_64' or 'arm64'",
223-
s
222+
"Unknown architecture: {s}. Use 'x86_64' or 'arm64'"
224223
)),
225224
}
226225
}
@@ -411,7 +410,7 @@ pub async fn build_bundle(opt: BuildBundleArgs) -> Result<Option<PathBuf>> {
411410
.arg("--release")
412411
.arg("--manifest-path")
413412
.arg(&manifest_path)
414-
.arg(format!("--target={}", target));
413+
.arg(format!("--target={target}"));
415414
handle_failure("cargo build", &command.output()?)?;
416415

417416
// Compile the wasm canary to a .wasm binary

0 commit comments

Comments
 (0)