Verify that svgoConfig.plugins is an array#397
Merged
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/gregberge/svgr/is9gs9oek |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #397 +/- ##
==========================================
+ Coverage 85.52% 85.63% +0.11%
==========================================
Files 30 30
Lines 518 522 +4
Branches 142 143 +1
==========================================
+ Hits 443 447 +4
Misses 62 62
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gregberge
approved these changes
Feb 16, 2020
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#384 introduced a breaking change in the
svgoConfigparser. Even if this wasn't intended, using an object for thepluginsconfig used to work, and a lot of people might be using such an incorrect config. The parsing currently fails silently. This PR makes the parser throw an error if anything other than an array is found.Test plan
I've written a new test case for handling of incorrect
pluginconfigs.