Fix worker SIGBUS on supervisor restart. (#5)

Author: samuel-williams-shopify

lib/async/service/supervisor/utilization_monitor.rb

@@ -38,6 +38,7 @@ def initialize(path, size: IO::Buffer::PAGE_SIZE * 8, segment_size: 512, growth_
 						@segment_size = segment_size
 						@growth_factor = growth_factor
 
+						File.unlink(path) rescue nil
 						@file = File.open(path, "w+b")
 						@file.truncate(size)
 						# Supervisor maps the file for reading worker data

releases.md

@@ -1,5 +1,9 @@
 # Releases
 
+## Unreleased
+
+  - Unlink shared memory file before opening on supervisor restart, preventing SIGBUS when workers still have the file mapped.
+
 ## v0.13.0
 
   - Add `worker_count` to `UtilizationMonitor` aggregated metrics per service, indicating how many workers contributed to each service's metrics (useful for utilization denominator).

test/async/service/utilization_monitor.rb

@@ -264,6 +264,37 @@
 		expect(monitor.status[:data]).to be == {}
 	end
 
+	it "does not resize existing file when recreating the utilization monitor" do
+		# When the supervisor restarts, it recreates the SegmentAllocator. Without unlink,
+		# File.open(path, "w+b") truncates the existing file. With unlink, we remove the file
+		# first so the new allocator gets a fresh file; any process with the old file mapped
+		# keeps a valid mapping to the unlinked inode.
+		allocator = Async::Service::Supervisor::UtilizationMonitor::SegmentAllocator.new(
+			shm_path, size: file_size, segment_size: segment_size
+		)
+		
+		# Resize to make the file larger than initial:
+		larger_size = file_size * 2
+		allocator.resize(larger_size)
+		
+		# Open the file and keep a handle; this simulates a worker that has it mapped:
+		existing_file = File.open(shm_path, "rb")
+		original_size = existing_file.size
+		expect(original_size).to be == larger_size
+		
+		allocator.close
+		
+		# Simulate supervisor restart - recreates allocator at same path:
+		Async::Service::Supervisor::UtilizationMonitor::SegmentAllocator.new(
+			shm_path, size: file_size, segment_size: segment_size
+		)
+		
+		# Our handle still references the original inode; it should not have been resized:
+		expect(existing_file.size).to be == original_size
+	ensure
+		existing_file&.close
+	end
+	
 	it "frees segments when workers are removed" do
 		# Register first worker
 		monitor.register(supervisor_controller)