Refs #130 | dialognodeedit: fix dialog UX issues for custom node attributes

- Fix Remove selected button staying enabled after deselection
- Fix getNodeShape() missing nodeShape="circle" for Circle case
- Fix getUserChoices() re-inserting stale attributes by rebuilding
  hash entirely from table contents on OK
- Fix Add button silent failure: highlight empty key/value fields
  with red colorize effect when Add is clicked with missing input
- Fix Add button label invisible due to missing color in stylesheet
- Fix Remove selected disabled state styling (was too dark)
- Set customAttributesTable horizontalHeaderStretchLastSection=true
  so Value column fills available width

Author: oxy86

src/forms/dialognodeedit.cpp

@@ -146,10 +146,11 @@ DialogNodeEdit::DialogNodeEdit(QWidget *parent,
             this, &DialogNodeEdit::getNodeIconFile);
 
     connect(ui->addPropertyBtn, &QPushButton::clicked, this, &DialogNodeEdit::on_addPropertyButton_clicked);
-    
-    connect(ui->customAttributesTable, &QTableWidget::itemSelectionChanged, [this]() {
-        ui->removePropertyBtn->setEnabled(true);
-    }); 
+
+    connect(ui->customAttributesTable, &QTableWidget::itemSelectionChanged, [this]()
+            { ui->removePropertyBtn->setEnabled(
+                  !ui->customAttributesTable->selectedItems().isEmpty()); });
+
     connect(ui->removePropertyBtn, &QPushButton::clicked, this, &DialogNodeEdit::on_removePropertyButton_clicked);
 }
 
@@ -184,6 +185,7 @@ void DialogNodeEdit::getNodeShape(const int &nodeShapeIndex)
         nodeShape = "box";
         break;
     case NodeShape::Circle:
+        nodeShape = "circle";
         break;
     case NodeShape::Diamond:
         nodeShape = "diamond";
@@ -344,12 +346,14 @@ void DialogNodeEdit::getUserChoices()
         break;
     }
 
-    // ui->customAttributesTable
+    // Rebuild custom attributes entirely from table contents
+    m_customAttributes.clear();
     for (int i = 0; i < ui->customAttributesTable->rowCount(); ++i)
     {
-        QString key = ui->customAttributesTable->item(i, 0)->text();
-        QString value = ui->customAttributesTable->item(i, 1)->text();
-        m_customAttributes.insert(key, value);
+        QTableWidgetItem *keyItem = ui->customAttributesTable->item(i, 0);
+        QTableWidgetItem *valueItem = ui->customAttributesTable->item(i, 1);
+        if (keyItem && valueItem && !keyItem->text().isEmpty())
+            m_customAttributes.insert(keyItem->text(), valueItem->text());
     }
     emit userChoices(nodeLabel, nodeSize, nodeColor, nodeShape, iconPath, m_customAttributes);
 }
@@ -382,21 +386,42 @@ void DialogNodeEdit::selectColor()
  */
 void DialogNodeEdit::on_addPropertyButton_clicked()
 {
-    QString key = ui->keyLineEdit->text();
-    QString value = ui->valueLineEdit->text();
-    if (!key.isEmpty() && !value.isEmpty())
+    QString key = ui->keyLineEdit->text().trimmed();
+    QString value = ui->valueLineEdit->text().trimmed();
+
+    // Highlight empty fields and return
+    QGraphicsColorizeEffect *effect = nullptr;
+    if (key.isEmpty())
     {
-        m_customAttributes.insert(key, value);
-        int row = ui->customAttributesTable->rowCount();
-        ui->customAttributesTable->insertRow(row);
-        ui->customAttributesTable->setItem(row, 0, new QTableWidgetItem(key));
-        ui->customAttributesTable->setItem(row, 1, new QTableWidgetItem(value));
-        ui->keyLineEdit->clear();
-        ui->valueLineEdit->clear();
+        effect = new QGraphicsColorizeEffect;
+        effect->setColor(QColor("red"));
+        ui->keyLineEdit->setGraphicsEffect(effect);
+    }
+    else
+    {
+        ui->keyLineEdit->setGraphicsEffect(nullptr);
     }
+    if (value.isEmpty())
+    {
+        effect = new QGraphicsColorizeEffect;
+        effect->setColor(QColor("red"));
+        ui->valueLineEdit->setGraphicsEffect(effect);
+    }
+    else
+    {
+        ui->valueLineEdit->setGraphicsEffect(nullptr);
+    }
+    if (key.isEmpty() || value.isEmpty())
+        return;
+
+    m_customAttributes.insert(key, value);
+    int row = ui->customAttributesTable->rowCount();
+    ui->customAttributesTable->insertRow(row);
+    ui->customAttributesTable->setItem(row, 0, new QTableWidgetItem(key));
+    ui->customAttributesTable->setItem(row, 1, new QTableWidgetItem(value));
+    ui->keyLineEdit->clear();
+    ui->valueLineEdit->clear();
 }
-
-
 /**
  * @brief Slot function called when the remove property button is clicked.
  *

src/forms/dialognodeedit.ui

@@ -275,7 +275,7 @@
          <bool>true</bool>
         </attribute>
         <attribute name="horizontalHeaderStretchLastSection">
-         <bool>false</bool>
+         <bool>true</bool>
         </attribute>
         <attribute name="verticalHeaderShowSortIndicator" stdset="0">
          <bool>true</bool>

src/qss/default.qss

@@ -279,18 +279,20 @@ QPushButton#removePropertyBtn {
     margin:0;
 }
 QPushButton#removePropertyBtn:disabled {
-    background-color: #32414B;
-    border: 1px solid #32414B;
-    color: #787878;
+    background-color: #aaa;
+    border: 1px solid #aaa;
+    color: #eee;
 }
 QPushButton#removePropertyBtn:hover {
     background-color:#ff0000;
 }
-QPushButton#addPropertyBtn{
-    background-color:#fff;
+QPushButton#addPropertyBtn {
+    background-color: #fff;
+    color: #222;
+    min-width: 60px;
     min-height: 1.5ex;
-    padding: 3px 0px;
-    margin:0;
+    padding: 3px 8px;
+    margin: 0;
 }
 
 QToolButton {