fix: prevent parent Pressable from firing onPress on link/task tap (#143)

* fix: prevent parent Pressable from firing onPress on link/task tap

* fix: enhance touch event handling to prevent unintended parent press actions

* fix: rename cancelJSTouch to cancelJSTouchForCheckboxTap for clarity in touch event handling

Author: hryhoriiK97

android/src/main/java/com/swmansion/enriched/markdown/EnrichedMarkdownInternalText.kt

@@ -9,6 +9,8 @@ import com.swmansion.enriched.markdown.accessibility.MarkdownAccessibilityHelper
 import com.swmansion.enriched.markdown.utils.text.interaction.CheckboxTouchHelper
 import com.swmansion.enriched.markdown.utils.text.view.LinkLongPressMovementMethod
 import com.swmansion.enriched.markdown.utils.text.view.applySelectableState
+import com.swmansion.enriched.markdown.utils.text.view.cancelJSTouchForCheckboxTap
+import com.swmansion.enriched.markdown.utils.text.view.cancelJSTouchForLinkTap
 import com.swmansion.enriched.markdown.utils.text.view.setupAsMarkdownTextView
 import com.swmansion.enriched.markdown.views.BlockSegmentView
 
@@ -53,8 +55,17 @@ class EnrichedMarkdownInternalText
     }
 
     override fun onTouchEvent(event: MotionEvent): Boolean {
-      if (checkboxTouchHelper.onTouchEvent(event)) return true
-      return super.onTouchEvent(event)
+      if (checkboxTouchHelper.onTouchEvent(event)) {
+        if (event.action == MotionEvent.ACTION_DOWN) {
+          cancelJSTouchForCheckboxTap(event)
+        }
+        return true
+      }
+      val result = super.onTouchEvent(event)
+      if (event.action == MotionEvent.ACTION_DOWN) {
+        cancelJSTouchForLinkTap(event)
+      }
+      return result
     }
 
     fun setJustificationMode(needsJustify: Boolean) {

android/src/main/java/com/swmansion/enriched/markdown/EnrichedMarkdownText.kt

@@ -20,6 +20,8 @@ import com.swmansion.enriched.markdown.utils.text.TailFadeInAnimator
 import com.swmansion.enriched.markdown.utils.text.interaction.CheckboxTouchHelper
 import com.swmansion.enriched.markdown.utils.text.view.LinkLongPressMovementMethod
 import com.swmansion.enriched.markdown.utils.text.view.applySelectableState
+import com.swmansion.enriched.markdown.utils.text.view.cancelJSTouchForCheckboxTap
+import com.swmansion.enriched.markdown.utils.text.view.cancelJSTouchForLinkTap
 import com.swmansion.enriched.markdown.utils.text.view.emitLinkLongPressEvent
 import com.swmansion.enriched.markdown.utils.text.view.emitLinkPressEvent
 import com.swmansion.enriched.markdown.utils.text.view.setupAsMarkdownTextView
@@ -259,8 +261,17 @@ class EnrichedMarkdownText
     }
 
     override fun onTouchEvent(event: MotionEvent): Boolean {
-      if (checkboxTouchHelper.onTouchEvent(event)) return true
-      return super.onTouchEvent(event)
+      if (checkboxTouchHelper.onTouchEvent(event)) {
+        if (event.action == MotionEvent.ACTION_DOWN) {
+          cancelJSTouchForCheckboxTap(event)
+        }
+        return true
+      }
+      val result = super.onTouchEvent(event)
+      if (event.action == MotionEvent.ACTION_DOWN) {
+        cancelJSTouchForLinkTap(event)
+      }
+      return result
     }
 
     companion object {

android/src/main/java/com/swmansion/enriched/markdown/utils/text/view/LinkEvents.kt

@@ -1,8 +1,11 @@
 package com.swmansion.enriched.markdown.utils.text.view
 
+import android.view.MotionEvent
 import android.view.View
+import android.widget.TextView
 import com.facebook.react.bridge.ReactContext
 import com.facebook.react.uimanager.UIManagerHelper
+import com.facebook.react.uimanager.events.NativeGestureUtil
 import com.swmansion.enriched.markdown.events.LinkLongPressEvent
 import com.swmansion.enriched.markdown.events.LinkPressEvent
 
@@ -19,3 +22,22 @@ fun View.emitLinkLongPressEvent(url: String) {
   val dispatcher = UIManagerHelper.getEventDispatcherForReactTag(reactContext, id)
   dispatcher?.dispatchEvent(LinkLongPressEvent(surfaceId, id, url))
 }
+
+/**
+ * Cancels the JS touch for an active link tap, preventing parent
+ * Pressable/TouchableOpacity from firing onPress for the same tap.
+ */
+fun TextView.cancelJSTouchForLinkTap(event: MotionEvent) {
+  val currentMovementMethod = movementMethod
+  if (currentMovementMethod is LinkLongPressMovementMethod && currentMovementMethod.isLinkTouchActive) {
+    NativeGestureUtil.notifyNativeGestureStarted(this, event)
+  }
+}
+
+/**
+ * Cancels the JS touch unconditionally, preventing parent
+ * Pressable/TouchableOpacity from firing onPress for the same gesture.
+ */
+fun View.cancelJSTouchForCheckboxTap(event: MotionEvent) {
+  NativeGestureUtil.notifyNativeGestureStarted(this, event)
+}

android/src/main/java/com/swmansion/enriched/markdown/utils/text/view/LinkLongPressMovementMethod.kt

@@ -22,6 +22,9 @@ class LinkLongPressMovementMethod : LinkMovementMethod() {
   private var startX = 0f
   private var startY = 0f
 
+  var isLinkTouchActive: Boolean = false
+    private set
+
   override fun onTouchEvent(
     widget: TextView,
     buffer: Spannable,
@@ -32,32 +35,30 @@ class LinkLongPressMovementMethod : LinkMovementMethod() {
         startX = event.x
         startY = event.y
 
-        // Identify if a LinkSpan exists at the touch coordinates
-        findLinkSpan(widget, buffer, event)?.let { span ->
-          scheduleLongPress(widget, span)
-        }
+        val span = findLinkSpan(widget, buffer, event)
+        isLinkTouchActive = span != null
+        span?.let { scheduleLongPress(widget, it) }
       }
 
       MotionEvent.ACTION_MOVE -> {
         val config = ViewConfiguration.get(widget.context)
-        // Cancel if the finger moves beyond the standard system touch slop
         if (abs(event.x - startX) > config.scaledTouchSlop ||
           abs(event.y - startY) > config.scaledTouchSlop
         ) {
           cancelLongPress()
+          isLinkTouchActive = false
         }
       }
 
       MotionEvent.ACTION_UP, MotionEvent.ACTION_CANCEL -> {
         cancelLongPress()
-        // Clear text selection to prevent the "stuck" highlight look
+        isLinkTouchActive = false
         if (widget.hasSelection()) {
           Selection.removeSelection(buffer)
         }
       }
     }
 
-    // Let the parent LinkMovementMethod handle the standard click logic
     val result = super.onTouchEvent(widget, buffer, event)
 
     // LinkMovementMethod sets a Selection highlight around the link on ACTION_DOWN,

ios/EnrichedMarkdown.mm

@@ -610,6 +610,25 @@ - (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &
   return EnrichedMarkdown.class;
 }
 
+- (facebook::react::SharedTouchEventEmitter)touchEventEmitterAtPoint:(CGPoint)point
+{
+  for (UIView *segment in _segmentViews) {
+    if (![segment isKindOfClass:[EnrichedMarkdownInternalText class]]) {
+      continue;
+    }
+    EnrichedMarkdownInternalText *textSegment = (EnrichedMarkdownInternalText *)segment;
+    CGPoint segmentPoint = [self convertPoint:point toView:textSegment.textView];
+    if ([textSegment.textView pointInside:segmentPoint withEvent:nil]) {
+      if (isPointOnInteractiveElement(textSegment.textView, segmentPoint)) {
+        return nil;
+      }
+      break;
+    }
+  }
+
+  return [super touchEventEmitterAtPoint:point];
+}
+
 - (void)textTapped:(UITapGestureRecognizer *)recognizer
 {
   UITextView *textView = (UITextView *)recognizer.view;

ios/EnrichedMarkdownText.mm

@@ -468,6 +468,18 @@ - (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &
   return EnrichedMarkdownText.class;
 }
 
+- (facebook::react::SharedTouchEventEmitter)touchEventEmitterAtPoint:(CGPoint)point
+{
+  if (_textView) {
+    CGPoint textViewPoint = [self convertPoint:point toView:_textView];
+    if (isPointOnInteractiveElement(_textView, textViewPoint)) {
+      return nil;
+    }
+  }
+
+  return [super touchEventEmitterAtPoint:point];
+}
+
 - (void)textTapped:(UITapGestureRecognizer *)recognizer
 {
   UITextView *textView = (UITextView *)recognizer.view;

ios/utils/LinkTapUtils.h

@@ -14,6 +14,9 @@ NSString *_Nullable linkURLAtTapLocation(UITextView *textView, UITapGestureRecog
 /// Returns the link URL at the given character range, or nil if none found.
 NSString *_Nullable linkURLAtRange(UITextView *textView, NSRange characterRange);
 
+/// Returns YES if the point (in textView coordinates) is on a link or task list checkbox.
+BOOL isPointOnInteractiveElement(UITextView *textView, CGPoint point);
+
 #ifdef __cplusplus
 }
 #endif

ios/utils/LinkTapUtils.m

@@ -26,3 +26,20 @@
   }
   return [textView.attributedText attribute:@"linkURL" atIndex:characterRange.location effectiveRange:NULL];
 }
+
+BOOL isPointOnInteractiveElement(UITextView *textView, CGPoint point)
+{
+  NSLayoutManager *layoutManager = textView.layoutManager;
+  CGPoint adjusted = CGPointMake(point.x - textView.textContainerInset.left, point.y - textView.textContainerInset.top);
+
+  NSUInteger charIndex = [layoutManager characterIndexForPoint:adjusted
+                                               inTextContainer:textView.textContainer
+                      fractionOfDistanceBetweenInsertionPoints:NULL];
+
+  if (charIndex >= textView.textStorage.length) {
+    return NO;
+  }
+
+  NSDictionary *attrs = [textView.attributedText attributesAtIndex:charIndex effectiveRange:NULL];
+  return attrs[@"linkURL"] != nil || [attrs[@"TaskItem"] boolValue];
+}