Skip to content

Commit 800795c

Browse files
committed
shorten in-code comment, add PR link
1 parent a62f697 commit 800795c

1 file changed

Lines changed: 1 addition & 8 deletions

File tree

FabricExample/e2e/examplesTests/events.e2e.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,7 @@ const pressBack = async () => {
1313
const awaitClassicalEventBehavior = async () => {
1414
if (device.getPlatform() === 'ios') {
1515
// The order of events in this test differs from the Paper version of the same test.
16-
// When screen is removed after using iOS native back button, native side notifies JS via:
17-
// 1. onDismissed => in reaction to this event, a navigation action is dispatched,
18-
// which causes emission of beforeRemove event;
19-
// 2. onDisappear => in reaction to this event, transitionEnd with closing=true is emitted.
20-
// On Fabric, these events are handled in the same order as the order of notifications from the native side.
21-
// On Paper, this is not the case - onDismissed is executed after two transitionEnd events are already handled.
22-
// onDismissed is dispatched asynchronously from the native side and this probably delays handling it on JS side
23-
// but I am not sure of the details why it is dispatched asynchronously.
16+
// Please see https://github.com/software-mansion/react-native-screens/pull/2785 for details.
2417
await expect(
2518
element(by.text('9. Chats | transitionStart | closing')),
2619
).toExist();

0 commit comments

Comments
 (0)