avoid running pointless tests if they are platform-specific

Author: kligarski

FabricExample/e2e/e2e-utils.ts

@@ -0,0 +1 @@
+export const describeIfiOS = device.getPlatform() === 'ios' ? describe : describe.skip;

FabricExample/e2e/issuesTests/Test528.e2e.ts

@@ -1,37 +1,26 @@
 import { device, expect, element, by } from 'detox';
+import { describeIfiOS } from '../e2e-utils';
 
-describe('Test528', () => {
+// Detox currently supports orientation only on iOS
+describeIfiOS('Test528', () => {
   beforeAll(async () => {
     await device.reloadReactNative();
   });
 
-  it('Test528 should exist', async () => {
-    await waitFor(element(by.id('root-screen-tests-Test528')))
-      .toBeVisible()
-      .whileElement(by.id('root-screen-examples-scrollview'))
-      .scroll(600, 'down', NaN, 0.85);
-
-    await expect(element(by.id('root-screen-tests-Test528'))).toBeVisible();
-    await element(by.id('root-screen-tests-Test528')).tap();
+  it('headerRight button should be visible after orientation change', async () => {
+    await expect(element(by.text('Custom Button'))).toBeVisible(100);
+    await device.setOrientation('landscape');
+    await expect(element(by.text('Custom Button'))).toBeVisible(100);
+    await device.setOrientation('portrait');
+    await expect(element(by.text('Custom Button'))).toBeVisible(100);
   });
 
-  // Detox currently supports orientation only on iOS
-  if (device.getPlatform() === 'ios') {
-    it('headerRight button should be visible after orientation change', async () => {
-      await expect(element(by.text('Custom Button'))).toBeVisible(100);
-      await device.setOrientation('landscape');
-      await expect(element(by.text('Custom Button'))).toBeVisible(100);
-      await device.setOrientation('portrait');
-      await expect(element(by.text('Custom Button'))).toBeVisible(100);
-    });
-
-    it('headerRight button should be visible after coming back from horizontal screen', async () => {
-      await element(by.text('Go to Screen 2')).tap();
-      await device.setOrientation('landscape');
-      await element(by.id('BackButton')).tap();
-      await expect(element(by.text('Custom Button'))).toBeVisible(100);
-      await device.setOrientation('portrait');
-      await expect(element(by.text('Custom Button'))).toBeVisible(100);
-    });
-  }
+  it('headerRight button should be visible after coming back from horizontal screen', async () => {
+    await element(by.text('Go to Screen 2')).tap();
+    await device.setOrientation('landscape');
+    await element(by.id('BackButton')).tap();
+    await expect(element(by.text('Custom Button'))).toBeVisible(100);
+    await device.setOrientation('portrait');
+    await expect(element(by.text('Custom Button'))).toBeVisible(100);
+  });
 });

FabricExample/e2e/issuesTests/Test577.e2e.ts

@@ -1,6 +1,8 @@
 import { device, expect, element, by } from 'detox';
+import { describeIfiOS } from '../e2e-utils';
 
-describe('Test577', () => {
+// Detox currently supports orientation only on iOS
+describeIfiOS('Test577', () => {
   beforeAll(async () => {
     await device.reloadReactNative();
   });
@@ -15,18 +17,15 @@ describe('Test577', () => {
     await element(by.id('root-screen-tests-Test577')).tap();
   });
 
-  // This issue is related to iOS modal
-  if (device.getPlatform() === 'ios') {
-    it('does not display content underneath modal with gesture disabled when attempting to close it', async () => {
-      await element(by.text('Open modal')).tap();
+  it('does not display content underneath modal with gesture disabled when attempting to close it', async () => {
+    await element(by.text('Open modal')).tap();
 
-      // Original bug was happening after a few consecutive attempts to close the modal.
-      // See this GIF: https://github.com/software-mansion/react-native-screens/issues/577#issue-666185758
-      // Decided to try it a few times.
-      for (let i = 0; i < 5; ++i) {
-        await element(by.text('Modal')).swipe('down', 'fast');
-        await expect(element(by.text('Open modal'))).not.toBeVisible();
-      }
-    });
-  }
+    // Original bug was happening after a few consecutive attempts to close the modal.
+    // See this GIF: https://github.com/software-mansion/react-native-screens/issues/577#issue-666185758
+    // Decided to try it a few times.
+    for (let i = 0; i < 5; ++i) {
+      await element(by.text('Modal')).swipe('down', 'fast');
+      await expect(element(by.text('Open modal'))).not.toBeVisible();
+    }
+  });
 });