Skip to content

fix: remove display setting on native side#2072

Closed
WoLewicki wants to merge 2 commits intomainfrom
@wolewicki/native-freeze-fix
Closed

fix: remove display setting on native side#2072
WoLewicki wants to merge 2 commits intomainfrom
@wolewicki/native-freeze-fix

Conversation

@WoLewicki
Copy link
Copy Markdown
Member

Description

Draft PR for fixing the display on native side.

@WoLewicki WoLewicki changed the title fix: quick workaround fix: remove display setting on native side Mar 21, 2024
@tboba
Copy link
Copy Markdown
Contributor

tboba commented Apr 15, 2024

@WoLewicki since there's open issue on RN repo, addressing why did we open this PR, should we close this PR?

@WoLewicki
Copy link
Copy Markdown
Member Author

I believe it can stick for now, and when we resolve the problem in the core, then we can close this one too. Also, this PR is not strictly connected to the new bugs coming from react-freeze, its just the matter of how we make it work in our case.

@kkafar
Copy link
Copy Markdown
Member

kkafar commented Mar 18, 2025

I do not remember what this PR was about & what issues in core you refer to in the conversation. Can we close it, or is it still relevant?

@WoLewicki
Copy link
Copy Markdown
Member Author

It was connected to our hacky solution for keeping the previous screen visible when applying freeze. Since react-freeze or rather Suspense(?) set the display to none under the hood for suspended components, we wanted it to not apply. This PR was trying to move this behavior to the native side instead of JS. I am not aware of the current state of those things, so it's up to you what we want to do with it next.

@kkafar
Copy link
Copy Markdown
Member

kkafar commented Mar 24, 2025

Okay, thanks for context. This is now set in JS. I'll close it since it won't be worked on within any reasonable timeline, and we can always reopen it when needed.

@kkafar kkafar closed this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants