Skip to content

lang: init_if_needed should run checks on constraints even if no init is needed#1096

Merged
armaniferrante merged 20 commits into
otter-sec:masterfrom
paul-schaaf:lang__init_if_needed_fix
Dec 8, 2021
Merged

lang: init_if_needed should run checks on constraints even if no init is needed#1096
armaniferrante merged 20 commits into
otter-sec:masterfrom
paul-schaaf:lang__init_if_needed_fix

Conversation

@paul-schaaf

Copy link
Copy Markdown
Contributor

closes #1034

Comment thread lang/src/error.rs
@paul-schaaf paul-schaaf marked this pull request as ready for review December 3, 2021 23:42
Comment thread lang/src/error.rs Outdated
@paul-schaaf

Copy link
Copy Markdown
Contributor Author

any more comments on this @armaniferrante ?

@paul-schaaf paul-schaaf force-pushed the lang__init_if_needed_fix branch from 06e3d6c to 6eb2ae2 Compare December 6, 2021 01:42
Comment thread CHANGELOG.md Outdated

@armaniferrante armaniferrante left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some nits.

Comment thread lang/syn/src/codegen/accounts/constraints.rs Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md
@armaniferrante armaniferrante merged commit 423ddde into otter-sec:master Dec 8, 2021
Comment thread ts/src/error.ts
AccountNotSigner: 3010,
AccountNotSystemOwned: 3011,
AccountNotInitialized: 3012,
AccountNotProgramData: 3013,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just came across these :) nice 👍

@jpbogle jpbogle Dec 10, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always used to search the github repo for the error codes 😆

Otter-0x4ka5h pushed a commit to Otter-0x4ka5h/anchor that referenced this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lang: init_if_needed does not verify fields if init is not needed

3 participants