Skip to content

change commitment message recent to processed #1128

Merged
paul-schaaf merged 9 commits into
otter-sec:masterfrom
Necmttn:update_commitment_recent_to_processed
Dec 20, 2021
Merged

change commitment message recent to processed #1128
paul-schaaf merged 9 commits into
otter-sec:masterfrom
Necmttn:update_commitment_recent_to_processed

Conversation

@Necmttn

@Necmttn Necmttn commented Dec 11, 2021

Copy link
Copy Markdown
Contributor

Cleanup for deprecated commitment messages. referred in here: #289
checked other deprecated messages did not find any:
https://github.com/solana-labs/solana-web3.js/blob/45923ca00e4cc1ed079d8e55ecbee83e5b4dc174/src/connection.ts#L230

@paul-schaaf

Copy link
Copy Markdown
Contributor

@Necmttn thanks for the PR! There is at least one max in the codebase (in the swap tests utils js file) that you can also remove.

pls also add a line under Unreleased -> Fixes in the changelog

@Necmttn

Necmttn commented Dec 17, 2021

Copy link
Copy Markdown
Contributor Author

@paul-schaaf updated. ✌️

Comment thread tests/swap/tests/utils/index.js Outdated
Comment thread CHANGELOG.md Outdated
@Necmttn

Necmttn commented Dec 19, 2021

Copy link
Copy Markdown
Contributor Author

Checked the failing test but seems like it's not related to this pr?

@paul-schaaf

Copy link
Copy Markdown
Contributor

merge master again @Necmttn

Comment thread ts/src/utils/rpc.ts Outdated
Comment thread CHANGELOG.md Outdated
@paul-schaaf paul-schaaf merged commit 483999e into otter-sec:master Dec 20, 2021
@Necmttn Necmttn deleted the update_commitment_recent_to_processed branch December 20, 2021 19:06
Otter-0x4ka5h pushed a commit to Otter-0x4ka5h/anchor that referenced this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants