Skip to content

spl: adding metadata account type#2014

Merged
armaniferrante merged 13 commits into
otter-sec:masterfrom
0xC0A1:misterkevin/metadata-account
Aug 13, 2022
Merged

spl: adding metadata account type#2014
armaniferrante merged 13 commits into
otter-sec:masterfrom
0xC0A1:misterkevin/metadata-account

Conversation

@0xC0A1

@0xC0A1 0xC0A1 commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

Allows for proper usage of MetadataAccounts.

Example

#[account(
        seeds = [b"metadata", mpl_token_metadata::ID.as_ref(), mint.key().as_ref()],
        seeds::program = mpl_token_metadata::ID,
        bump,
        constraint = nft.uses.as_ref().map_or(false, |u| u.remaining > 0) @ AppError::NFTHasNoUses
)]
pub nft: Account<'info, MetadataAccount>

@vercel

vercel Bot commented Jun 29, 2022

Copy link
Copy Markdown

@kevinrodriguez-io is attempting to deploy a commit to the 200ms Team on Vercel.

A member of the Team first needs to authorize it.

Comment thread spl/src/metadata.rs
Comment thread spl/src/metadata.rs Outdated
@0xC0A1 0xC0A1 requested a review from armaniferrante June 29, 2022 21:06
Comment thread spl/src/metadata.rs Outdated
@0xC0A1

0xC0A1 commented Jul 18, 2022

Copy link
Copy Markdown
Contributor Author

@armaniferrante @kklas Do you guys know what is that unrelated error in Tests / Core Tests?
Also the PR seem to be ready as per the new spec right @samuelvanderwaal ?

@kklas

kklas commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

Seems like you have a linter error.

Run the following in the repo root directory

$ cargo fmt -- --check
$ cargo clippy --all-targets -- -D warnings
$ cargo test

@0xC0A1

0xC0A1 commented Jul 18, 2022

Copy link
Copy Markdown
Contributor Author

@armaniferrante @kklas @kespinola @samuelvanderwaal Informally re-requesting review because the re-request button isn't working.

@callensm

callensm commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

@kevinrodriguez-io rebase this branch from master to pull in the clippy error fixes and rerun the tests.

Comment thread CHANGELOG.md Outdated
@armaniferrante armaniferrante merged commit d3ee9b5 into otter-sec:master Aug 13, 2022
yf-castel pushed a commit to castle-finance/anchor that referenced this pull request Aug 15, 2022
yf-castel pushed a commit to castle-finance/anchor that referenced this pull request Aug 15, 2022
Henry-E pushed a commit to Henry-E/anchor that referenced this pull request Dec 6, 2022
Otter-0x4ka5h pushed a commit to Otter-0x4ka5h/anchor that referenced this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants