Skip to content

use rustls in reqwest dep#2385

Closed
kevinheavey wants to merge 6 commits into
otter-sec:masterfrom
kevinheavey:patch-1
Closed

use rustls in reqwest dep#2385
kevinheavey wants to merge 6 commits into
otter-sec:masterfrom
kevinheavey:patch-1

Conversation

@kevinheavey

@kevinheavey kevinheavey commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

This should remove the need for libssl, or at least remove two things that require it

@vercel

vercel Bot commented Feb 3, 2023

Copy link
Copy Markdown

@kevinheavey is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@Henry-E

Henry-E commented Feb 3, 2023

Copy link
Copy Markdown

Great, so these changes just narrow down the features that anchor uses? Can you say more about what rustls is. Is this worthy of a changelog?

@kevinheavey

Copy link
Copy Markdown
Contributor Author

The default native-tls feature of reqwest relies on OpenSSL being installed, which is not something Cargo can take care of for you (hence why the Anchor docs tell you to install a bunch of Linux packages). rustls not the default because it results in bigger binaries and is less mature.

Solana crates like cargo-build-bpf already use the rustls feature though so I'm not worried about those disadvantages.

A changelog entry would be good so people can take a step out of their workflows if needed

@Henry-E

Henry-E commented Feb 6, 2023

Copy link
Copy Markdown

Ok, well if it's good enough for cargo-build-bpf, then it's probably good enough for us.

@vercel

vercel Bot commented Feb 6, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
anchor-docs ⬜️ Ignored (Inspect) Feb 6, 2023 at 6:23PM (UTC)

@Henry-E Henry-E closed this Feb 6, 2023
@Henry-E Henry-E reopened this Feb 6, 2023
@Henry-E

Henry-E commented Feb 6, 2023

Copy link
Copy Markdown
Merge attempt failed
Changes must be made through a pull request.

Getting this error when trying to squash and merge. Very odd

@Henry-E

Henry-E commented Feb 7, 2023

Copy link
Copy Markdown

Github keeps erroring when trying to merge this PR, so just going to remake it in a new PR and merge that instead.

@Henry-E Henry-E closed this Feb 7, 2023
@Henry-E Henry-E mentioned this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants