Skip to content

cli: Fix commit based anchor_version override#2704

Merged
acheroncrypto merged 2 commits into
otter-sec:masterfrom
acheroncrypto:fix-commit-based-anchor_version-override
Nov 17, 2023
Merged

cli: Fix commit based anchor_version override#2704
acheroncrypto merged 2 commits into
otter-sec:masterfrom
acheroncrypto:fix-commit-based-anchor_version-override

Conversation

@acheroncrypto

Copy link
Copy Markdown
Collaborator

Problem

toolchain.anchor_version override with commits after 0.29.0 doesn't work. This is because commit based installations do not have the correct version name inside the binary(they only have the tag version). For example

[toolchain]
anchor_version = "0.29.0-cded9de0a43302f8f51947405e0bf3bc6997b908"

doesn't work but

[toolchain]
anchor_version = "0.28.0-51578bcbc522d5398dbfa9d020f28fb797eb5815"

works(because no version compare logic).

Summary of changes

Get the current version from the executing binary name or default to the crate version if the version doesn't exist in the binary name.

@vercel

vercel Bot commented Nov 17, 2023

Copy link
Copy Markdown

@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto added bug Something isn't working cli labels Nov 17, 2023
@acheroncrypto acheroncrypto merged commit d28414e into otter-sec:master Nov 17, 2023
Otter-0x4ka5h pushed a commit to Otter-0x4ka5h/anchor that referenced this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cli

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant