Skip to content

pass cargo args to idl generation#3059

Merged
acheroncrypto merged 2 commits into
otter-sec:masterfrom
debridge-finance:pass-cargo-args-while-idl-build
Jun 28, 2024
Merged

pass cargo args to idl generation#3059
acheroncrypto merged 2 commits into
otter-sec:masterfrom
debridge-finance:pass-cargo-args-while-idl-build

Conversation

@biryukovmaxim

Copy link
Copy Markdown
Contributor

closes #3054

@vercel

vercel Bot commented Jun 27, 2024

Copy link
Copy Markdown

@biryukovmaxim is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto added idl related to the IDL, either program or client side feature labels Jun 27, 2024

@acheroncrypto acheroncrypto left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks great other than the breaking change (new parameter).

Comment thread idl/src/build.rs
Comment thread idl/src/build.rs Outdated
@biryukovmaxim biryukovmaxim force-pushed the pass-cargo-args-while-idl-build branch from 3063167 to 6cf09da Compare June 27, 2024 15:19

@acheroncrypto acheroncrypto left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One last thing before we merge, could you note this feature in the CHANGELOG?

@biryukovmaxim biryukovmaxim force-pushed the pass-cargo-args-while-idl-build branch from 6cf09da to 1eabcdc Compare June 28, 2024 10:03
@biryukovmaxim

Copy link
Copy Markdown
Contributor Author

Thanks! One last thing before we merge, could you note this feature in the CHANGELOG?

done

@acheroncrypto acheroncrypto left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature idl related to the IDL, either program or client side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compilation Error with Passing Cargo args when build program when IDL Generation is enabled in Anchor 0.30

2 participants