idl: Fix defined types with unsupported fields not producing an error#4088
Merged
Conversation
|
@acheroncrypto is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Otter-0x4ka5h
pushed a commit
to Otter-0x4ka5h/anchor
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As mentioned in #4073, defined types (structs and enums) do not get included in the IDL if they contain unsupported type(s).
For example, with the following type:
IDL build successfully, but there is no type definition for
BrokenTypein thetypessection. This is not only unintuitive, but it also breaks other parts of the framework e.g.declare_program!and TS package usage.Summary of changes
Make unsupported field types of defined types produce an error instead of omitting the type definition altogether.
Example error output:
Note: This is a fix but also a breaking change because, although unlikely, programs that compiled before this change might not compile after this change if they are using unsupported types in their public API.
Fixes #4073