idl: Fix address constraint not resolving constants that have numbers in their identifiers#4144
Merged
Conversation
|
@acheroncrypto is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
acheroncrypto
added
idl
Otter-0x4ka5h
pushed a commit
to Otter-0x4ka5h/anchor
that referenced
this pull request
Mar 25, 2026
…rs in their identifiers (otter-sec#4144)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As explained in #4143, the IDL generation does not resolve
addressconstraint if a constant identifier has a number in its name.Summary of changes
addressconstraint not resolving constants that have numbers in their identifiers by allowing digits (viachar::is_ascii_digit).char::is_uppercasecheck tochar::is_ascii_uppercasefor consistency (non-ASCII methods such aschar::is_numericallow all sorts of characters other than the expected0-9).address = ADDRESS_WITH_NUMBER_V2Fixes #4143