Skip to content

Commit 186ef0f

Browse files
MatriXDharaNarey
authored andcommitted
Fix: added BCryptPasswordEncoder, updateed data.sql with bcrypt-hashed passwords
1 parent 7ce622b commit 186ef0f

File tree

8 files changed

+16
-13
lines changed

8 files changed

+16
-13
lines changed

src/main/java/org/springframework/samples/petclinic/security/BasicAuthenticationConfig.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import org.springframework.security.config.annotation.method.configuration.EnableMethodSecurity;
1010
import org.springframework.security.config.annotation.web.builders.HttpSecurity;
1111
import org.springframework.security.config.annotation.web.configurers.AbstractHttpConfigurer;
12+
import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder;
1213
import org.springframework.security.crypto.password.DelegatingPasswordEncoder;
1314
import org.springframework.security.crypto.password.NoOpPasswordEncoder;
1415
import org.springframework.security.crypto.password.PasswordEncoder;
@@ -27,12 +28,11 @@ public class BasicAuthenticationConfig {
2728

2829
@Bean
2930
public PasswordEncoder passwordEncoder() {
30-
var encoders = Map.of("noop", NoOpPasswordEncoder.getInstance());
31-
var passwordEncoder = new DelegatingPasswordEncoder("noop", encoders);
32-
passwordEncoder.setDefaultPasswordEncoderForMatches(NoOpPasswordEncoder.getInstance());
33-
return passwordEncoder;
31+
return new BCryptPasswordEncoder();
3432
}
3533

34+
35+
3636
@Bean
3737
public SecurityFilterChain filterChain(HttpSecurity http) throws Exception {
3838
// @formatter:off

src/main/resources/db/h2/data.sql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,11 @@ INSERT INTO visits (pet_id, visit_date, description) VALUES
6767
(7, '2013-01-04', 'spayed');
6868

6969
-- Insert Admin User
70-
INSERT INTO users (username, password, enabled) VALUES
71-
('admin', 'admin', TRUE);
70+
INSERT INTO users (username, password, enabled) VALUES
71+
('admin', '$2a$10$ymaklWBnpBKlgdMgkjWVF.GMGyvH8aDuTK.glFOaKw712LHtRRymS', TRUE);
7272

7373
-- Assign Roles to Admin
7474
INSERT INTO roles (username, role) VALUES
7575
('admin', 'ROLE_OWNER_ADMIN'),
7676
('admin', 'ROLE_VET_ADMIN'),
77-
('admin', 'ROLE_ADMIN');
77+
('admin', 'ROLE_ADMIN');

src/main/resources/db/hsqldb/data.sql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ INSERT INTO visits VALUES (2, 8, '2013-01-02', 'rabies shot');
5252
INSERT INTO visits VALUES (3, 8, '2013-01-03', 'neutered');
5353
INSERT INTO visits VALUES (4, 7, '2013-01-04', 'spayed');
5454

55-
INSERT INTO users(username,password,enabled) VALUES ('admin','{noop}admin', true);
55+
INSERT INTO users(username, password, enabled) VALUES
56+
('admin', '$2a$10$ymaklWBnpBKlgdMgkjWVF.GMGyvH8aDuTK.glFOaKw712LHtRRymS', TRUE);
5657

5758
INSERT INTO roles (username, role) VALUES ('admin', 'ROLE_OWNER_ADMIN');
5859
INSERT INTO roles (username, role) VALUES ('admin', 'ROLE_VET_ADMIN');

src/main/resources/db/hsqldb/schema.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ CREATE INDEX visits_pet_id ON visits (pet_id);
6767

6868
CREATE TABLE users (
6969
username VARCHAR(20) NOT NULL ,
70-
password VARCHAR(20) NOT NULL ,
70+
password VARCHAR(60) NOT NULL ,
7171
enabled BOOLEAN DEFAULT TRUE NOT NULL ,
7272
PRIMARY KEY (username)
7373
);

src/main/resources/db/mysql/data.sql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ INSERT IGNORE INTO visits VALUES (2, 8, '2011-03-04', 'rabies shot');
5252
INSERT IGNORE INTO visits VALUES (3, 8, '2009-06-04', 'neutered');
5353
INSERT IGNORE INTO visits VALUES (4, 7, '2008-09-04', 'spayed');
5454

55-
INSERT IGNORE INTO users(username,password,enabled) VALUES ('admin','{noop}admin', true);
55+
INSERT IGNORE INTO users (username, password, enabled) VALUES
56+
('admin', '$2a$10$ymaklWBnpBKlgdMgkjWVF.GMGyvH8aDuTK.glFOaKw712LHtRRymS', TRUE);
5657

5758
INSERT IGNORE INTO roles (username, role) VALUES ('admin', 'ROLE_OWNER_ADMIN');
5859
INSERT IGNORE INTO roles (username, role) VALUES ('admin', 'ROLE_VET_ADMIN');

src/main/resources/db/mysql/schema.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ CREATE TABLE IF NOT EXISTS visits (
5656

5757
CREATE TABLE IF NOT EXISTS users (
5858
username VARCHAR(20) NOT NULL ,
59-
password VARCHAR(20) NOT NULL ,
59+
password VARCHAR(60) NOT NULL ,
6060
enabled TINYINT NOT NULL DEFAULT 1 ,
6161
PRIMARY KEY (username)
6262
) engine=InnoDB;

src/main/resources/db/postgres/data.sql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ INSERT INTO visits (pet_id, visit_date, description) SELECT 8, '2011-03-04', 'ra
5252
INSERT INTO visits (pet_id, visit_date, description) SELECT 8, '2009-06-04', 'neutered' WHERE NOT EXISTS (SELECT * FROM visits WHERE id=3);
5353
INSERT INTO visits (pet_id, visit_date, description) SELECT 7, '2008-09-04', 'spayed' WHERE NOT EXISTS (SELECT * FROM visits WHERE id=4);
5454

55-
INSERT INTO users(username,password,enabled) SELECT 'admin','{noop}admin', true WHERE NOT EXISTS (SELECT * FROM users WHERE username='admin');
55+
INSERT INTO users(username, password, enabled) VALUES
56+
('admin', '$2a$10$ymaklWBnpBKlgdMgkjWVF.GMGyvH8aDuTK.glFOaKw712LHtRRymS', TRUE);
5657

5758
INSERT INTO roles (username, role) SELECT 'admin', 'ROLE_OWNER_ADMIN' WHERE NOT EXISTS (SELECT * FROM roles WHERE id=1);
5859
INSERT INTO roles (username, role) SELECT 'admin', 'ROLE_VET_ADMIN' WHERE NOT EXISTS (SELECT * FROM roles WHERE id=2);

src/main/resources/db/postgres/schema.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ CREATE INDEX ON visits (pet_id);
5353

5454
CREATE TABLE IF NOT EXISTS users (
5555
username VARCHAR(20) NOT NULL ,
56-
password VARCHAR(20) NOT NULL ,
56+
password VARCHAR(60) NOT NULL ,
5757
enabled boolean NOT NULL DEFAULT true ,
5858
CONSTRAINT pk_users PRIMARY KEY (username)
5959
);

0 commit comments

Comments
 (0)