Fix SigV4 signing mismatch issue with ?v query parameter (opensearch-project#9730)

* Fix SigV4 signing issue with ?v query parameter

Signed-off-by: Zhongnan Su <szhongna@amazon.com>

* Changeset file for PR opensearch-project#9730 created/updated

---------

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

Author: zhongnansu

changelogs/fragments/9730.yml

@@ -0,0 +1,2 @@
+fix:
+- Fix SigV4 signing mismatch issue with ?v query parameter ([#9730](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9730))

src/plugins/data_source/server/legacy/http_aws_es/connector.js

@@ -9,7 +9,7 @@ import { Sha256 } from '@aws-crypto/sha256-js';
 import { AbortController } from '@aws-sdk/abort-controller';
 import { defaultProvider } from '@aws-sdk/credential-provider-node';
 import { NodeHttpHandler } from '@aws-sdk/node-http-handler';
-import queryString from 'query-string';
+
 const HttpConnector = require('elasticsearch/src/lib/connectors/http');
 
 class HttpAmazonESConnector extends HttpConnector {
@@ -94,7 +94,12 @@ class HttpAmazonESConnector extends HttpConnector {
   createRequest(params, reqParams) {
     const [pathname = '/', queryStr = ''] = (reqParams.path || '').split('?', 2);
 
-    const queryParams = queryStr ? queryString.parse(queryStr) : undefined;
+    const queryParams = {};
+    if (queryStr) {
+      for (const [key, value] of new URLSearchParams(queryStr)) {
+        queryParams[key] = value ?? '';
+      }
+    }
 
     const request = new HttpRequest({
       ...this.endpoint,

src/plugins/data_source/server/legacy/http_aws_es/connector.test.js

@@ -233,4 +233,58 @@ describe('createRequest', () => {
     expect(request.path).to.equal('/test');
     expect(request.query).to.be.empty;
   });
+
+  it('should treat query parameter without value as empty string', () => {
+    const host = new Host();
+    const connector = new Connector(host, {
+      awsConfig: {
+        region: 'us-east-1',
+        credentials: defaultProvider(),
+      },
+    });
+
+    const params = { method: 'GET' };
+    const reqParams = { method: 'GET', path: '/test?v', headers: {} };
+
+    const request = connector.createRequest(params, reqParams);
+
+    expect(request.path).to.equal('/test');
+    expect(request.query).to.have.property('v', '');
+  });
+
+  it('should treat query parameter with explicit empty value as empty string', () => {
+    const host = new Host();
+    const connector = new Connector(host, {
+      awsConfig: {
+        region: 'us-east-1',
+        credentials: defaultProvider(),
+      },
+    });
+
+    const params = { method: 'GET' };
+    const reqParams = { method: 'GET', path: '/test?v=', headers: {} };
+
+    const request = connector.createRequest(params, reqParams);
+
+    expect(request.path).to.equal('/test');
+    expect(request.query).to.have.property('v', '');
+  });
+
+  it('should correctly parse standard key-value query parameters', () => {
+    const host = new Host();
+    const connector = new Connector(host, {
+      awsConfig: {
+        region: 'us-east-1',
+        credentials: defaultProvider(),
+      },
+    });
+
+    const params = { method: 'GET' };
+    const reqParams = { method: 'GET', path: '/test?foo=bar&baz=qux', headers: {} };
+
+    const request = connector.createRequest(params, reqParams);
+
+    expect(request.path).to.equal('/test');
+    expect(request.query).to.deep.equal({ foo: 'bar', baz: 'qux' });
+  });
 });