Remove global parse_length_delimited* functions

These functions are not very useful and are a source of confusion
for users.

Issue #328

Author: stepancheg

protobuf-test-common/src/serialize_deserialize_tests.rs

@@ -5,7 +5,9 @@ use protobuf::*;
 
 pub fn test_serialize_deserialize_length_delimited<M : Message + PartialEq>(msg: &M) {
     let serialized_bytes = msg.write_length_delimited_to_bytes().unwrap();
-    let parsed = parse_length_delimited_from_bytes::<M>(&serialized_bytes).unwrap();
+    let mut is = CodedInputStream::from_bytes(&serialized_bytes);
+    let parsed = is.read_message().unwrap();
+    is.check_eof().unwrap();
     assert_eq!(*msg, parsed);
 }
 

protobuf-test/src/common/v2/test_basic.rs

@@ -295,6 +295,8 @@ fn test_parse_length_delimited_from_network_smoke() {
     });
 
     let mut tcp_stream = net::TcpStream::connect(addr).expect("connect");
-    let test1: Test1 = parse_length_delimited_from_reader(&mut tcp_stream).expect("parse...");
+    let mut is = CodedInputStream::new(&mut tcp_stream);
+    let test1: Test1 = is.read_message().expect("read_message");
     assert_eq!(10, test1.get_a());
+    is.check_eof().expect("check_eof");
 }

protobuf/src/core.rs

@@ -226,28 +226,3 @@ pub fn parse_from_carllerche_bytes<M : Message>(
     // Call trait explicitly to avoid accidental construction from `&[u8]`
     WithCodedInputStream::with_coded_input_stream(bytes, |is| parse_from::<M>(is))
 }
-
-/// Parse length-delimited message from stream.
-///
-/// Read varint length first, and read messages of that length then.
-pub fn parse_length_delimited_from<M : Message>(
-    is: &mut CodedInputStream,
-) -> ProtobufResult<M> {
-    is.read_message::<M>()
-}
-
-/// Parse length-delimited message from `Read`.
-pub fn parse_length_delimited_from_reader<M : Message>(
-    r: &mut Read,
-) -> ProtobufResult<M> {
-    // TODO: wrong: we may read length first, and then read exact number of bytes needed
-    r.with_coded_input_stream(|is| is.read_message::<M>())
-}
-
-/// Parse length-delimited message from bytes.
-// TODO: currently it's not possible to know how many bytes read from slice.
-pub fn parse_length_delimited_from_bytes<M : Message>(
-    bytes: &[u8],
-) -> ProtobufResult<M> {
-    bytes.with_coded_input_stream(|is| is.read_message::<M>())
-}

protobuf/src/lib.rs

@@ -23,9 +23,6 @@ pub use core::parse_from_bytes;
 pub use core::parse_from_reader;
 #[cfg(feature = "bytes")]
 pub use core::parse_from_carllerche_bytes;
-pub use core::parse_length_delimited_from;
-pub use core::parse_length_delimited_from_reader;
-pub use core::parse_length_delimited_from_bytes;
 pub use enums::ProtobufEnum;
 pub use oneof::Oneof;
 pub use stream::CodedInputStream;