fixed the tests

Author: stephanrauh

projects/ngx-extended-pdf-viewer/src/lib/pdf-dummy-components/pdf-dummy-components.component.spec.ts

@@ -238,7 +238,7 @@ describe('PdfDummyComponentsComponent', () => {
       component.addMissingStandardWidgets();
 
       // Should process each required ID
-      expect(getElementByIdSpy).toHaveBeenCalledTimes(194); // Number of entries in requiredIds array (scaleSelect is included in the array)
+      expect(getElementByIdSpy).toHaveBeenCalledTimes(195); // Number of entries in requiredIds array (scaleSelect is included in the array)
     });
 
     it('should handle duplicate IDs in requiredIds array', () => {

projects/ngx-extended-pdf-viewer/src/lib/pdf-script-loader.service.spec.ts

@@ -242,15 +242,18 @@ describe('PDFScriptLoaderService', () => {
     });
 
     it('should return false in server-side rendering environment', () => {
-      // Mock server-side environment
+      // jsdom marks `window` on globalThis as non-configurable, so `delete`
+      // fails — but it's still writable, so assigning undefined makes
+      // `typeof window === 'undefined'` true for the guard under test.
       const originalWindow = (global as any).window;
-      delete (global as any).window;
+      (global as any).window = undefined;
 
-      const requiresES5 = (service as any).iOSVersionRequiresES5();
-      expect(requiresES5).toBe(false);
-
-      // Restore window
-      (global as any).window = originalWindow;
+      try {
+        const requiresES5 = (service as any).iOSVersionRequiresES5();
+        expect(requiresES5).toBe(false);
+      } finally {
+        (global as any).window = originalWindow;
+      }
     });
   });
 
@@ -398,14 +401,17 @@ describe('PDFScriptLoaderService', () => {
     });
 
     it('should handle server-side rendering environment', () => {
-      // Mock server-side environment
+      // jsdom marks `window` on globalThis as non-configurable, so `delete`
+      // fails — but it's still writable, so assigning undefined makes
+      // `typeof window === 'undefined'` true for the guard under test.
       const originalWindow = (global as any).window;
-      delete (global as any).window;
-
-      expect(() => service.ngOnDestroy()).not.toThrow();
+      (global as any).window = undefined;
 
-      // Restore window
-      (global as any).window = originalWindow;
+      try {
+        expect(() => service.ngOnDestroy()).not.toThrow();
+      } finally {
+        (global as any).window = originalWindow;
+      }
     });
   });
 

projects/ngx-extended-pdf-viewer/src/lib/secondary-toolbar/pdf-secondary-toolbar/pdf-secondary-toolbar.component.test.ts

@@ -380,14 +380,20 @@ describe('PdfSecondaryToolbarComponent', () => {
 
   describe('checkVisibilityRecursively', () => {
     it('should return 0 for server-side rendering', () => {
+      // jsdom marks `window` on globalThis as non-configurable, so `delete`
+      // fails — but it's still writable, so assigning undefined makes
+      // `typeof window === 'undefined'` true for the guard under test.
       const originalWindow = global.window;
-      delete (global as any).window;
+      (global as any).window = undefined;
 
-      const element = document.createElement('div');
-      const result = component['checkVisibilityRecursively'](element);
+      try {
+        const element = document.createElement('div');
+        const result = component['checkVisibilityRecursively'](element);
 
-      expect(result).toBe(0);
-      global.window = originalWindow;
+        expect(result).toBe(0);
+      } finally {
+        global.window = originalWindow;
+      }
     });
 
     it('should return 0 for elements with display none style', () => {