feat(new config option): load_order

[Zeioth]

New config options

-- list order ["modification_time", "creation_time", "filename"]
load_order = "modification_time",

Comments

These options allow modifying almost anything UX related, and should satisfy the needs of most users without adding excessive complexity.

This is just a proposal and I'm open to changes. If this is not part of your future vision for the project and you prefer to reject it, that's ok too. In any case, let me know.

Once more, thank you for creating another awesome piece of open source software 🫂

Update

I've cleaned the PR to ship only the load_order option. So it should be safe to merge now.

[stevearc]

I like the sorting change; I think that's relatively small but also a nice value add.

For formatting, I try to avoid implementations like this where there are a bunch of different config options to handle small stylistic preferences for end users. You end up building an entire config language almost like a mini-DSL, with increasingly complex code to support it. And someone always wants "just one more option" to configure things the way they want it. These days my preferred approach is to provide a default option, and then give the user a hook to do their own custom logic. In this case, that would mean allowing the user to pass their own format_item function in the config. That'll also require some small tweaks to the existing function, since we're loading the session data and referencing it from inside of the default format_item. We'll need to instead pass the data with the names to vim.ui.select so it's available to the custom format_item hooks.

[Zeioth]

That makes sense. I've cleaned this PR to have load_order only 👍

[stevearc]

Looks good! Just fix the typecheck errors and it's good to merge

[stevearc]

Thanks!