Skip to content

Commit c19ad44

Browse files
committed
rename variable and add jsdocs
1 parent b4847c4 commit c19ad44

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

code/lib/cli-storybook/src/sandbox-templates.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@ export type Template = {
9898
};
9999
/** Additional CI steps in case this template has special needs during CI. */
100100
extraCiSteps?: {
101-
useNode22?: boolean;
101+
// Some sandboxes (e.g. Angular) rely on Node 22.22.1 as minimum supported version and threfore it needs enforcing, even if the CI image comes with a different node version.
102+
ensureMinNodeVersion?: boolean;
102103
};
103104
/** Additional options to pass to the initiate command when initializing Storybook. */
104105
initOptions?: {
@@ -657,7 +658,7 @@ export const baseTemplates = {
657658
useCsfFactory: true,
658659
},
659660
extraCiSteps: {
660-
useNode22: true,
661+
ensureMinNodeVersion: true,
661662
},
662663
expected: {
663664
framework: '@storybook/angular',
@@ -675,7 +676,7 @@ export const baseTemplates = {
675676
useCsfFactory: true,
676677
},
677678
extraCiSteps: {
678-
useNode22: true,
679+
ensureMinNodeVersion: true,
679680
},
680681
expected: {
681682
framework: '@storybook/angular',

scripts/ci/sandboxes.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,11 @@ function getSandboxSetupSteps(template: string) {
2222
const extraSteps = [];
2323
const templateData = sandboxTemplates.allTemplates[template as TemplateKey];
2424

25-
if (templateData.extraCiSteps?.useNode22) {
25+
if (templateData.extraCiSteps?.ensureMinNodeVersion) {
2626
extraSteps.push({
2727
'node/install': {
2828
'install-yarn': true,
29+
// Currently using Node 22.22.1 as minimum supported version for Angular sandboxes
2930
'node-version': '22.22.1',
3031
},
3132
});

0 commit comments

Comments
 (0)