don't crash when user opens a URI without having a browser installed (fixes #6798)

Author: westnordost

app/src/androidMain/kotlin/de/westnordost/streetcomplete/screens/about/AboutScreen.kt

@@ -35,6 +35,7 @@ import de.westnordost.streetcomplete.ui.common.settings.PreferenceCategory
 import de.westnordost.streetcomplete.util.ktx.displayLanguage
 import org.jetbrains.compose.resources.stringResource
 import androidx.compose.ui.tooling.preview.Preview
+import de.westnordost.streetcomplete.ui.ktx.tryOpenUri
 
 @Composable
 fun AboutScreen(
@@ -80,7 +81,7 @@ fun AboutScreen(
 
                 Preference(
                     name = stringResource(Res.string.about_title_license),
-                    onClick = { uriHandler.openUri("https://www.gnu.org/licenses/gpl-3.0.html") },
+                    onClick = { uriHandler.tryOpenUri("https://www.gnu.org/licenses/gpl-3.0.html") },
                 ) {
                     Text("GPLv3")
                     OpenInBrowserIcon()
@@ -100,12 +101,12 @@ fun AboutScreen(
 
                 Preference(
                     name = stringResource(Res.string.about_title_faq),
-                    onClick = { uriHandler.openUri("https://wiki.openstreetmap.org/wiki/StreetComplete/FAQ") },
+                    onClick = { uriHandler.tryOpenUri("https://wiki.openstreetmap.org/wiki/StreetComplete/FAQ") },
                 ) { OpenInBrowserIcon() }
 
                 Preference(
                     name = stringResource(Res.string.about_title_report_error),
-                    onClick = { uriHandler.openUri("https://github.com/streetcomplete/StreetComplete/issues") },
+                    onClick = { uriHandler.tryOpenUri("https://github.com/streetcomplete/StreetComplete/issues") },
                 ) { OpenInBrowserIcon() }
 
                 Preference(
@@ -125,7 +126,7 @@ fun AboutScreen(
 
                 Preference(
                     name = stringResource(Res.string.about_title_translate),
-                    onClick = { uriHandler.openUri("https://poeditor.com/join/project/IE4GC127Ki") },
+                    onClick = { uriHandler.tryOpenUri("https://poeditor.com/join/project/IE4GC127Ki") },
                     description = stringResource(
                         Res.string.about_description_translate,
                         Locale.current.displayLanguage ?: Locale.current.language,
@@ -135,7 +136,7 @@ fun AboutScreen(
 
                 Preference(
                     name = stringResource(Res.string.about_title_repository),
-                    onClick = { uriHandler.openUri("https://github.com/streetcomplete/StreetComplete") },
+                    onClick = { uriHandler.tryOpenUri("https://github.com/streetcomplete/StreetComplete") },
                 ) { OpenInBrowserIcon() }
             }
 
@@ -144,13 +145,13 @@ fun AboutScreen(
                 if (context.isInstalledViaGooglePlay()) {
                     Preference(
                         name = stringResource(Res.string.about_title_rate),
-                        onClick = { uriHandler.openUri("market://details?id=${context.packageName}") },
+                        onClick = { uriHandler.tryOpenUri("market://details?id=${context.packageName}") },
                     ) { OpenInBrowserIcon() }
                 }
 
                 Preference(
                     name = stringResource(Res.string.about_title_feedback),
-                    onClick = { uriHandler.openUri("https://github.com/streetcomplete/StreetComplete/discussions") },
+                    onClick = { uriHandler.tryOpenUri("https://github.com/streetcomplete/StreetComplete/discussions") },
                 ) { OpenInBrowserIcon() }
             }
         }
@@ -162,7 +163,7 @@ fun AboutScreen(
         } else {
             DonationsDialog(
                 onDismissRequest = { showDonateDialog = false },
-                onClickLink = { uriHandler.openUri(it) }
+                onClickLink = { uriHandler.tryOpenUri(it) }
             )
         }
     }

app/src/androidMain/kotlin/de/westnordost/streetcomplete/screens/main/messages/MessageDialog.kt

@@ -6,6 +6,7 @@ import androidx.compose.ui.platform.LocalUriHandler
 import de.westnordost.streetcomplete.data.messages.Message
 import de.westnordost.streetcomplete.screens.settings.SettingsActivity
 import de.westnordost.streetcomplete.screens.user.achievements.AchievementDialog
+import de.westnordost.streetcomplete.ui.ktx.tryOpenUri
 import kotlin.reflect.KClass
 
 /** Dialog that shows a Message */
@@ -47,7 +48,7 @@ fun MessageDialog(
                 unreadMessageCount = message.unreadMessages,
                 onDismissRequest = onDismissRequest,
                 onClickOpenMessages = {
-                    uriHandler.openUri("https://www.openstreetmap.org/messages/inbox")
+                    uriHandler.tryOpenUri("https://www.openstreetmap.org/messages/inbox")
                 }
             )
         }
@@ -59,7 +60,7 @@ fun MessageDialog(
                 onClickOpenWeeklyOsm = {
                     // note that weeklyOSM website is smart enough to show the site in the user
                     // preferred language
-                    uriHandler.openUri("https://www.weeklyosm.eu")
+                    uriHandler.tryOpenUri("https://www.weeklyosm.eu")
                 },
                 onToggleDontNotifyAgain = { dontNotifyAgain ->
                     onToggleDontNotifyAgain(Message.NewWeeklyOsm::class, dontNotifyAgain)
@@ -71,7 +72,7 @@ fun MessageDialog(
             CalendarEventDialog(
                 event = message.event,
                 onDismissRequest = onDismissRequest,
-                onClickOpenEvent = { uriHandler.openUri(message.event.url) },
+                onClickOpenEvent = { uriHandler.tryOpenUri(message.event.url) },
                 onToggleDontNotifyAgain = { dontNotifyAgain ->
                     onToggleDontNotifyAgain(Message.NewCalendarEvent::class, dontNotifyAgain)
                 }

app/src/androidMain/kotlin/de/westnordost/streetcomplete/screens/user/edits/EditTypeDialog.kt

@@ -32,6 +32,7 @@ import de.westnordost.streetcomplete.ui.common.OpenInBrowserIcon
 import de.westnordost.streetcomplete.ui.theme.headlineSmall
 import org.jetbrains.compose.resources.stringResource
 import androidx.compose.ui.tooling.preview.Preview
+import de.westnordost.streetcomplete.ui.ktx.tryOpenUri
 
 /** Shows the details for a certain quest type in a custom dialog. */
 @Composable
@@ -91,7 +92,7 @@ private fun EditTypeDetails(
 
         editType.wikiLink?.let { wikiLink ->
             OutlinedButton(
-                onClick = { uriHandler.openUri("https://wiki.openstreetmap.org/wiki/$wikiLink") }
+                onClick = { uriHandler.tryOpenUri("https://wiki.openstreetmap.org/wiki/$wikiLink") }
             ) {
                 OpenInBrowserIcon()
                 Text(

app/src/commonMain/kotlin/de/westnordost/streetcomplete/screens/user/edits/CountryDialog.kt

@@ -31,6 +31,7 @@ import de.westnordost.streetcomplete.util.ktx.displayRegion
 import de.westnordost.streetcomplete.util.ktx.getDisplayRegion
 import org.jetbrains.compose.resources.stringResource
 import androidx.compose.ui.tooling.preview.Preview
+import de.westnordost.streetcomplete.ui.ktx.tryOpenUri
 
 /** Shows the details for a certain country as a dialog. */
 @Composable
@@ -112,7 +113,7 @@ private fun CountryInfoDetails(
             onClick = {
                 val britishCountryName = countryLocale.getDisplayRegion(Locale("en-GB"))
                 if (britishCountryName != null) {
-                    uriHandler.openUri("https://wiki.openstreetmap.org/wiki/$britishCountryName")
+                    uriHandler.tryOpenUri("https://wiki.openstreetmap.org/wiki/$britishCountryName")
                 }
             }
         ) {

app/src/commonMain/kotlin/de/westnordost/streetcomplete/screens/user/links/LinkRow.kt

@@ -25,6 +25,7 @@ import org.jetbrains.compose.resources.StringResource
 import org.jetbrains.compose.resources.painterResource
 import org.jetbrains.compose.resources.stringResource
 import androidx.compose.ui.tooling.preview.Preview
+import de.westnordost.streetcomplete.ui.ktx.tryOpenUri
 
 /** Display a single link category from the link collection */
 @Composable
@@ -58,7 +59,7 @@ fun LinkRow(link: Link, modifier: Modifier = Modifier) {
     val uriHandler = LocalUriHandler.current
     Row(
         modifier = modifier
-            .clickable { uriHandler.openUri(link.url) }
+            .clickable { uriHandler.tryOpenUri(link.url) }
             .padding(8.dp),
         horizontalArrangement = Arrangement.spacedBy(8.dp),
     ) {

app/src/commonMain/kotlin/de/westnordost/streetcomplete/screens/user/profile/ProfileScreen.kt

@@ -39,6 +39,7 @@ import androidx.compose.ui.unit.dp
 import androidx.compose.ui.unit.sp
 import de.westnordost.streetcomplete.resources.*
 import de.westnordost.streetcomplete.ui.ktx.toDp
+import de.westnordost.streetcomplete.ui.ktx.tryOpenUri
 import de.westnordost.streetcomplete.ui.theme.headlineLarge
 import de.westnordost.streetcomplete.ui.theme.titleLarge
 import de.westnordost.streetcomplete.util.image.fileBitmapPainter
@@ -116,7 +117,7 @@ fun ProfileScreen(viewModel: ProfileViewModel) {
         ) {
             val uriHandler = LocalUriHandler.current
             Button(onClick = {
-                uriHandler.openUri("https://www.openstreetmap.org/user/" + viewModel.userName.value)
+                uriHandler.tryOpenUri("https://www.openstreetmap.org/user/" + viewModel.userName.value)
             }) {
                 Icon(painterResource(Res.drawable.ic_open_in_browser_24), null)
                 Spacer(Modifier.width(8.dp))

app/src/commonMain/kotlin/de/westnordost/streetcomplete/ui/ktx/UriHandler.kt

@@ -0,0 +1,15 @@
+package de.westnordost.streetcomplete.ui.ktx
+
+import androidx.compose.ui.platform.UriHandler
+
+/**
+ * Try to open given URL in browser. Returns `false` if given [uri] is invalid and/or can't be
+ * handled by the system (e.g. if no browser is installed).
+ */
+fun UriHandler.tryOpenUri(uri: String): Boolean =
+    try {
+        openUri(uri)
+        return true
+    } catch (e: IllegalArgumentException) {
+        return false
+    }