when cold-restarting application, actually always update the feeds

Author: westnordost

app/src/androidMain/kotlin/de/westnordost/streetcomplete/StreetCompleteApplication.kt

@@ -2,10 +2,8 @@ package de.westnordost.streetcomplete
 
 import android.app.Application
 import android.content.ComponentCallbacks2
-import android.net.ConnectivityManager
 import android.os.LocaleList
 import androidx.appcompat.app.AppCompatDelegate
-import androidx.core.content.getSystemService
 import androidx.work.ExistingPeriodicWorkPolicy
 import androidx.work.PeriodicWorkRequest
 import androidx.work.WorkManager
@@ -43,7 +41,6 @@ import de.westnordost.streetcomplete.data.quest.questModule
 import de.westnordost.streetcomplete.data.upload.uploadModule
 import de.westnordost.streetcomplete.data.urlconfig.urlConfigModule
 import de.westnordost.streetcomplete.data.user.UserLoginController
-import de.westnordost.streetcomplete.data.user.UserUpdater
 import de.westnordost.streetcomplete.data.user.achievements.achievementDefinitionsModule
 import de.westnordost.streetcomplete.data.user.achievements.achievementsModule
 import de.westnordost.streetcomplete.data.user.achievements.editTypeAliasesModule
@@ -165,7 +162,7 @@ class StreetCompleteApplication : Application() {
             editHistoryController.deleteSyncedOlderThan(nowAsEpochMilliseconds() - ApplicationConstants.MAX_UNDO_HISTORY_AGE)
         }
 
-        feedsUpdater.updateDaily()
+        feedsUpdater.updateNow()
 
         enqueuePeriodicCleanupWork()
 

app/src/androidMain/kotlin/de/westnordost/streetcomplete/screens/main/MainActivity.kt

@@ -222,7 +222,7 @@ class MainActivity :
         supportFragmentManager.commit { add(LocationRequestFragment(), TAG_LOCATION_REQUEST) }
 
         lifecycle.addObserver(questAutoSyncer)
-        feedsUpdater.updateDaily()
+        feedsUpdater.updateAtMostDaily()
 
         locationManager = FineLocationManager(this, this::onLocationChanged)
 

app/src/commonMain/kotlin/de/westnordost/streetcomplete/data/FeedsUpdater.kt

@@ -18,12 +18,15 @@ class FeedsUpdater(
     private val achievementsSource: AchievementsSource,
 ) {
     /** update at most daily */
-    fun updateDaily() {
+    fun updateAtMostDaily() {
         val today = LocalDate.now()
         val lastUpdate = prefs.lastFeedUpdate
         if (lastUpdate != null && lastUpdate >= today) return
+    }
 
-        prefs.lastFeedUpdate = today
+    /** (force) update now */
+    fun updateNow() {
+        prefs.lastFeedUpdate = LocalDate.now()
 
         userUpdater.update()
         val disabledMessageTypes = prefs.disabledMessageTypes