fixup! ✨(backend) add metadata collection of VAD, connection and chat events

Author: lebaudantoine

src/backend/core/tests/rooms/test_api_rooms_start_recording.py

@@ -510,7 +510,10 @@ def test_start_recording_calls_metadata_collector_start(
 
         response = client.post(
             f"/api/v1.0/rooms/{room.id}/start-recording/",
-            {"mode": "screen_recording", "options": {"transcribe": True}},
+            {
+                "mode": "screen_recording",
+                "options": {"transcribe": True, "collect_metadata": True},
+            },
             format="json",
         )
 
@@ -521,20 +524,25 @@ def test_start_recording_calls_metadata_collector_start(
 
 
 @pytest.mark.parametrize(
-    "metadata_enabled,transcribe",
+    "metadata_enabled,options",
     [
-        (False, True),
-        (False, False),
-        (True, False),
+        # Metadata collector disabled, regardless of transcribe option
+        (False, {"transcribe": True}),
+        (False, {"transcribe": False}),
+        (False, None),
+        # Metadata collector enabled, but transcribe is False or missing
+        (True, {"transcribe": False}),
         (True, None),
+        # Metadata collector enabled, transcribe True, but collect_metadata explicitly False
+        (True, {"transcribe": True, "collect_metadata": False}),
     ],
 )
 def test_start_recording_does_not_call_metadata_collector_start_when_conditions_not_met(
     settings,
     mock_worker_service_factory,
     mock_worker_manager,
     metadata_enabled,
-    transcribe,
+    options,
 ):
     """Should not call MetadataCollectorService.start when conditions are not met."""
     settings.RECORDING_ENABLE = True
@@ -547,9 +555,9 @@ def test_start_recording_does_not_call_metadata_collector_start_when_conditions_
     client = APIClient()
     client.force_login(user)
 
-    options = {}
-    if transcribe is not None:
-        options["transcribe"] = transcribe
+    payload = {"mode": "screen_recording"}
+    if options is not None:
+        payload["options"] = options
 
     with mock.patch(
         "core.api.viewsets.MetadataCollectorService"
@@ -559,9 +567,7 @@ def test_start_recording_does_not_call_metadata_collector_start_when_conditions_
 
         response = client.post(
             f"/api/v1.0/rooms/{room.id}/start-recording/",
-            {"mode": "screen_recording", "options": options}
-            if options
-            else {"mode": "screen_recording"},
+            payload,
             format="json",
         )