fix: run clippy and rustfmt; fix issues (#34)

Author: justinchuby

src/git.rs

@@ -18,7 +18,9 @@ pub fn get_head() -> Result<String> {
 pub fn get_paths_from_cmd(paths_cmd: &str) -> Result<Vec<AbsPath>> {
     debug!("Running paths_cmd: {}", paths_cmd);
     if paths_cmd.is_empty() {
-        return Err(anyhow::Error::msg("paths_cmd is empty. Please provide an executable command."));
+        return Err(anyhow::Error::msg(
+            "paths_cmd is empty. Please provide an executable command.",
+        ));
     }
     let argv = shell_words::split(paths_cmd).context("failed to split paths_cmd")?;
     debug!("Parsed paths_cmd: {:?}", argv);

src/lint_config.rs

@@ -173,10 +173,7 @@ pub fn get_linters_from_config(
             );
         }
 
-        linters = linters
-            .into_iter()
-            .filter(|linter| taken_linters.contains(&linter.code))
-            .collect();
+        linters.retain(|linter| taken_linters.contains(&linter.code));
     }
 
     // Apply --skip
@@ -190,10 +187,7 @@ pub fn get_linters_from_config(
                 all_linters,
             );
         }
-        linters = linters
-            .into_iter()
-            .filter(|linter| !skipped_linters.contains(&linter.code))
-            .collect();
+        linters.retain(|linter| !skipped_linters.contains(&linter.code));
     }
     Ok(linters)
 }

src/linter.rs

@@ -160,7 +160,7 @@ impl Linter {
                     original: None,
                     replacement: None,
                 };
-                return vec![err_lint];
+                vec![err_lint]
             }
             Ok(messages) => messages,
         }

src/main.rs

@@ -6,18 +6,19 @@ use clap::Parser;
 
 use lintrunner::{
     do_init, do_lint,
+    git::get_head,
     init::check_init_changed,
     lint_config::{get_linters_from_config, LintRunnerConfig},
     log_utils::setup_logger,
     path::AbsPath,
     persistent_data::{ExitInfo, PersistentDataStore, RunInfo},
     rage::do_rage,
     render::print_error,
-    PathsOpt, RenderOpt, RevisionOpt, git::get_head,
+    PathsOpt, RenderOpt, RevisionOpt,
 };
 use log::debug;
 
-const VERSION: &'static str = env!("CARGO_PKG_VERSION");
+const VERSION: &str = env!("CARGO_PKG_VERSION");
 
 #[derive(Debug, Parser)]
 #[clap(version, name = "lintrunner", infer_subcommands(true))]

src/persistent_data.rs

@@ -47,7 +47,7 @@ impl RunInfo {
     // this run.
     fn dir_name(&self) -> String {
         let args = blake3::hash(self.args.join("_").as_bytes()).to_string();
-        self.timestamp.clone().replace(":", "-").replace("+", "_") + "_" + &args
+        self.timestamp.clone().replace(':', "-").replace('+', "_") + "_" + &args
     }
 }
 

src/render.rs

@@ -54,7 +54,13 @@ pub fn render_lint_messages_oneline(
         writeln!(
             stdout,
             "{}:{}:{} :{} {} [{}/{}]",
-            display_path, line_number, column, severity, description, lint_message.code, lint_message.name
+            display_path,
+            line_number,
+            column,
+            severity,
+            description,
+            lint_message.code,
+            lint_message.name
         )?;
     }