Skip to content

Validate variables and simplify lowercase#5128

Merged
ferrarimarco merged 1 commit intomainfrom
lowercase
Jan 11, 2024
Merged

Validate variables and simplify lowercase#5128
ferrarimarco merged 1 commit intomainfrom
lowercase

Conversation

@ferrarimarco
Copy link
Copy Markdown
Collaborator

Proposed changes

  • Validate variables representing boolean values.
  • Group global variables in the same sections.
  • Declare variables as lowercase with the 'declare -l' shell builtin for more clarity.

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label labels Jan 11, 2024
@ferrarimarco ferrarimarco self-assigned this Jan 11, 2024
- Validate variables representing boolean values.
- Group global variables in the same sections.
- Declare variables as lowercase with the 'declare -l' shell builtin for
  more clarity.
Copy link
Copy Markdown
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ferrarimarco ferrarimarco added this pull request to the merge queue Jan 11, 2024
Merged via the queue into main with commit 4a28fc5 Jan 11, 2024
@ferrarimarco ferrarimarco deleted the lowercase branch January 11, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants