Merged
Conversation
Collaborator
Author
|
(pushing a test only first, I want to confirm that this fails without the proposed fix that I'll push later) |
35cb85c to
091d019
Compare
Hanse00
reviewed
Feb 9, 2024
Hanse00
previously approved these changes
Feb 9, 2024
Collaborator
Hanse00
left a comment
There was a problem hiding this comment.
Looks good. I left a comment for a clarifying question, but it's not one I think should hold up this work. Just looking to make sure I understand context.
091d019 to
716d0b1
Compare
Terrascan runs initialization anyway when scanning files, so there's no point in running it at build time. Also, this works around a Terrascan bug that caused it to fail its initialization if $HOME/.terrascan directory is not present. This happens on GitHub Actions because it configures a $HOME directory that is different from ours.
716d0b1 to
f5bdb26
Compare
Hanse00
approved these changes
Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Terrascan runs initialization anyway when scanning files, so there's no point in running it at build time. Also, this works around a Terrascan bug that caused it to fail its initialization if $HOME/.terrascan directory is not present. This happens on GitHub Actions because it configures a $HOME directory that is different from ours.
Readiness checklist
In order to have this pull request merged, complete the following tasks.
Pull request author tasks
I added the
Fix #ISSUE_NUMBERlabel to the description of the pull request.Super-linter maintainer tasks
breakingif this change breaks compatibility with the previous released version.automation,bug,documentation,enhancement,infrastructure.