CSS sourcemaps#698
Merged
Rich-Harris merged 9 commits intomasterfrom Jul 10, 2017
Merged
Conversation
Member
Author
|
Removing the [WIP]. Not addressed here — how to generate a sourcemap for concatenated CSS files (e.g. the CSS bundle generated by rollup-plugin-svelte). Probably outside Svelte's remit, though it's a little annoying to have to keep decoding, manipulating, combining and reencoding sourcemap mappings. (Sourcemaps are a pain.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The immediate goal of this PR is to add support for CSS sourcemaps. The approach I'm taking is to move all the CSS logic into a new
Stylesheetclass, which is responsible for creating/transforming a separate MagicString instance.This will make it a bit easier to remove unused rules altogether, and do e.g. whitespace removal. Ultimately we could even have multiple stylesheets attached to a component (for example, if a component had two or more
<link rel='stylesheet'>tags, if we get round to that).