fix integration test

- actually create directory with real test
- check for directory, then delete
- use rimraf.sync
- remove temp var

Author: tabrindle

integration_tests/__tests__/clear_cache.test.js

@@ -12,26 +12,23 @@
 const fs = require('fs');
 const os = require('os');
 const path = require('path');
-const {cleanup, writeFiles} = require('../utils');
 const runJest = require('../runJest');
 const skipOnWindows = require('../../scripts/skip_on_windows');
+const rimraf = require('rimraf');
 
 const CACHE = path.resolve(os.tmpdir(), 'clear_cache_directory');
-const DIR = path.resolve(os.tmpdir(), 'clear_cache');
 
 skipOnWindows.suite();
 
-beforeEach(() => cleanup(DIR));
-afterAll(() => cleanup(DIR));
-
 describe('jest --clearCache', () => {
-  test('clearing cache results in exit status 0', () => {
-    writeFiles(DIR, {
-      '.watchmanconfig': '',
-      'package.json': '{}',
-    });
+  test('normal run results in cache directory being written', () => {
+    const {status} = runJest('clear_cache', [`--cacheDirectory=${CACHE}`]);
 
-    const {status, stdout, stderr} = runJest(DIR, [
+    expect(fs.existsSync(CACHE)).toBe(true);
+    expect(status).toBe(0);
+  });
+  test('clearCache results in deleted directory and exit status 0', () => {
+    const {status, stdout, stderr} = runJest('clear_cache', [
       '--clearCache',
       `--cacheDirectory=${CACHE}`,
     ]);

integration_tests/clear_cache/__tests__/clear_cache.test.js

@@ -0,0 +1,10 @@
+/**
+ * Copyright (c) 2014-present, Facebook, Inc. All rights reserved.
+ *
+ * This source code is licensed under the BSD-style license found in the
+ * LICENSE file in the root directory of this source tree. An additional grant
+ * of patent rights can be found in the PATENTS file in the same directory.
+ */
+'use strict';
+
+test('stub', () => expect(1).toBe(1));

integration_tests/clear_cache/package.json

@@ -0,0 +1,5 @@
+{
+  "jest": {
+    "testEnvironment": "node"
+  }
+}

packages/jest-cli/src/cli/index.js

@@ -69,20 +69,11 @@ const runCLI = async (
     );
 
     if (argv.clearCache) {
-      let clearCacheError;
-
       configs.map(config => {
-        rimraf(config.cacheDirectory, [], () => {
-          clearCacheError = true;
-          process.stderr.write(`Unable to clear ${config.cacheDirectory}\n`);
-        });
+        rimraf.sync(config.cacheDirectory);
         process.stdout.write(`Cleared ${config.cacheDirectory}\n`);
       });
 
-      if (clearCacheError) {
-        process.exit(1);
-      }
-
       process.exit(0);
     }