Add same line matching question

It would not be a stretch to say that this question does not warrant existence. Some times train stations that aren't on the line are allegedly on the line and vice versa. A better API would improve this significantly. Thankfully hider mode prevents contradictions, but this should really be refined.

Author: taibeled

src/components/QuestionCards.tsx

@@ -299,6 +299,16 @@ export const MatchingQuestionComponent = ({
                     )}
                 </>
             );
+            break;
+        case "same-train-line":
+            questionSpecific = (
+                <span className="px-2 text-center text-orange-500">
+                    Warning: The train line data is based on OpenStreetMap and
+                    may have fewer train stations than expected. If you are
+                    using this tool, assure that the other players are also
+                    using this tool.
+                </span>
+            );
     }
 
     return (
@@ -344,6 +354,13 @@ export const MatchingQuestionComponent = ({
                             Station Has Same Length Question (must be in hiding
                             zone mode)
                         </SelectItem>
+                        <SelectItem
+                            value="same-train-line"
+                            disabled={!$displayHidingZones}
+                        >
+                            Station On Same Train Line Question (must be in
+                            hiding zone mode)
+                        </SelectItem>
                     </SelectContent>
                 </Select>
             </SidebarMenuItem>

src/components/ZoneSidebar.tsx

@@ -18,7 +18,7 @@ import { Label } from "./ui/label";
 import { Checkbox } from "./ui/checkbox";
 import { useEffect, useState } from "react";
 import { geoJSON } from "leaflet";
-import { findPlacesInZone } from "@/maps/api";
+import { findPlacesInZone, trainLineNodeFinder } from "@/maps/api";
 import * as turf from "@turf/turf";
 import osmtogeojson from "osmtogeojson";
 import { unionize } from "@/maps/geo-utils";
@@ -63,11 +63,12 @@ export const ZoneSidebar = () => {
                 ),
             ).features;
 
-            $questions.forEach((question) => {
+            for (const question of $questions) {
                 if (
                     question.id === "matching" &&
                     (question.data.type === "same-first-letter-station" ||
-                        question.data.type === "same-length-station")
+                        question.data.type === "same-length-station" ||
+                        question.data.type === "same-train-line")
                 ) {
                     const location = turf.point([
                         question.data.lng,
@@ -79,6 +80,29 @@ export const ZoneSidebar = () => {
                         turf.featureCollection(places) as any,
                     );
 
+                    if (question.data.type === "same-train-line") {
+                        const nodes = await trainLineNodeFinder(
+                            nearestTrainStation.properties.id,
+                        );
+
+                        if (nodes.length === 0) {
+                            toast.warning(
+                                `No train line found for ${nearestTrainStation.properties["name:en"] || nearestTrainStation.properties.name}`,
+                            );
+                            continue;
+                        } else {
+                            places = places.filter((place: any) => {
+                                const id = parseInt(
+                                    place.properties.id.split("/")[1],
+                                );
+
+                                return question.data.same
+                                    ? nodes.includes(id)
+                                    : !nodes.includes(id);
+                            });
+                        }
+                    }
+
                     const englishName =
                         nearestTrainStation.properties["name:en"] ||
                         nearestTrainStation.properties.name;
@@ -116,7 +140,7 @@ export const ZoneSidebar = () => {
                         });
                     }
                 }
-            });
+            }
 
             const unionized = unionize($questionFinishedMapData)!;
 

src/maps/api.ts

@@ -222,6 +222,43 @@ export const fetchCoastline = async () => {
     return data;
 };
 
+export const trainLineNodeFinder = async (node: string): Promise<number[]> => {
+    const nodeId = node.split("/")[1];
+
+    const query = `
+[out:json];
+node(${nodeId});
+wr(bn);
+out geom;
+    `;
+
+    const data = await getOverpassData(query, "Finding train lines...");
+
+    const geoJSON = osmtogeojson(data);
+
+    const nodes: number[] = [];
+
+    geoJSON.features.forEach((feature: any) => {
+        // For relations
+        if (feature && feature.id && feature.id.startsWith("node")) {
+            nodes.push(parseInt(feature.id.split("/")[1]));
+        }
+    });
+
+    data.elements.forEach((element: any) => {
+        // For ways
+        if (element && element.type === "node") {
+            nodes.push(element.id);
+        } else if (element && element.type === "way") {
+            nodes.push(...element.nodes);
+        }
+    });
+
+    const uniqNodes = _.uniq(nodes);
+
+    return uniqNodes;
+};
+
 export const findPlacesInZone = async (
     filter: string,
     loadingText?: string,

src/maps/matching.ts

@@ -1,5 +1,5 @@
 import { hiderMode, mapGeoJSON, questions } from "@/lib/context";
-import { findAdminBoundary, findPlacesInZone, iconColors } from "./api";
+import { findAdminBoundary, findPlacesInZone, iconColors, trainLineNodeFinder } from "./api";
 import * as turf from "@turf/turf";
 import type { LatLng } from "leaflet";
 import _ from "lodash";
@@ -39,6 +39,10 @@ export interface SameLengthStationMatchingQuestion
     type: "same-length-station";
 }
 
+export interface SameTrainLineMatchingQuestion extends BaseMatchingQuestion {
+    type: "same-train-line";
+}
+
 export interface LetterMatchingZoneQuestion extends BaseMatchingQuestion {
     type: "letter-zone";
     cat: MatchingZoneQuestion;
@@ -49,7 +53,8 @@ export type MatchingQuestion =
     | AirportMatchingQuestion
     | LetterMatchingZoneQuestion
     | SameFirstLetterStationMatchingQuestion
-    | SameLengthStationMatchingQuestion;
+    | SameLengthStationMatchingQuestion
+    | SameTrainLineMatchingQuestion;
 
 export const adjustPerMatching = async (
     question: MatchingQuestion,
@@ -73,6 +78,9 @@ export const adjustPerMatching = async (
         case "same-length-station": {
             return mapData;
         }
+        case "same-train-line": {
+            return mapData;
+        }
         case "zone": {
             boundary = await findAdminBoundary(
                 question.lat,
@@ -211,7 +219,8 @@ export const hiderifyMatching = async (question: MatchingQuestion) => {
 
     if (
         question.type === "same-first-letter-station" ||
-        question.type === "same-length-station"
+        question.type === "same-length-station" ||
+        question.type === "same-train-line"
     ) {
         const hiderPoint = turf.point([
             $hiderMode.longitude,
@@ -236,6 +245,22 @@ export const hiderifyMatching = async (question: MatchingQuestion) => {
             places as any,
         );
 
+        if (question.type === "same-train-line") {
+            const nodes = await trainLineNodeFinder(
+                nearestSeekerTrainStation.properties.id,
+            );
+
+            const hiderId = parseInt(
+                nearestHiderTrainStation.properties.id.split("/")[1],
+            );
+
+            if (nodes.includes(hiderId)) {
+                question.same = true;
+            } else {
+                question.same = false;
+            }
+        }
+
         const hiderEnglishName =
             nearestHiderTrainStation.properties["name:en"] ||
             nearestHiderTrainStation.properties.name;