Upgrade to new architecture (#13)

* chore: remove flipper config

* chore: bump ruby version

* feat: attempt to upgrade to new arch

* feat: add expo example app - so we can test it works on expo

* feat: add example new arch and keep old

* fix: fix example run config

* feat: make renderer work on new arch

* chore: bump node version

* fix: fix build for new arch

* feat: complete new architecture migration with old arch support

- Add event emitter support for TurboModules (addListener/removeListeners)
- Fix iOS getSampleRate method signature for old arch bridge compatibility
- Fix Android getSampleRate method signature (remove extra parameter)
- Create old arch package (ElementaryTurboPackage) for Android bridge mode
- Remove pre-generated codegen folders - now generated at consumer build time
- Update iOS header to import spec from Pods headers
- Consolidate iOS example to single project with arch toggle
- Update Podfile with clear architecture toggle comment
- Update C++ standard to c++20 for React Native 0.78 compatibility
- Fix ESLint config to use correct package name (@react-native)

Both architectures tested and working on iOS and Android.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(ci): resolve CI validation failures

- Add missing ESLint dependencies (eslint-plugin-ft-flow, hermes-eslint)
- Add metro-react-native-babel-preset for Jest
- Fix Jest modulePathIgnorePatterns to exclude example_old
- Remove codegen from bob targets (runs at consumer build time)
- Update Java version from 11 to 17 for React Native 0.78

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* style: fix prettier formatting in example app

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat: add Expo example app

- Add example-expo/ with Expo SDK 53 and React Native 0.79
- Configure expo-dev-client for development builds
- Add metro.config.js with resolveRequest to fix React duplicates in monorepo
- Add react-native.config.js for proper codegen integration
- Update root package.json with example-expo script
- Update .gitignore for Expo generated folders

Note: This library requires a development build (`expo run:ios/android`)
and cannot run in Expo Go due to native C++ Elementary Audio dependency.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(ci): exclude example-expo from lint and build

- Add example-expo/ to eslintIgnore
- Add example-expo and example_old to tsconfig.build.json exclude

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: correct exports types paths in package.json

The types paths incorrectly included /src/ which doesn't exist in the build output.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: exclude example folders from typecheck

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: txbrown

.elementaryspec

@@ -0,0 +1,22 @@
+{
+  "modules": {
+    "Elementary": {
+      "type": "NativeModule",
+      "methods": {
+        "getSampleRate": {
+          "type": "Promise",
+          "returnType": "number"
+        },
+        "applyInstructions": {
+          "type": "method",
+          "arguments": [
+            {
+              "name": "message",
+              "type": "string"
+            }
+          ]
+        }
+      }
+    }
+  }
+} 

.github/workflows/ci.yml

@@ -82,7 +82,7 @@ jobs:
         uses: actions/setup-java@v3
         with:
           distribution: 'zulu'
-          java-version: '11'
+          java-version: '17'
 
       - name: Finalize Android SDK
         if: env.turbo_cache_hit != 1

.gitignore

@@ -43,9 +43,11 @@ android.iml
 # Cocoapods
 #
 example/ios/Pods
+example_old/ios/Pods
 
 # Ruby
 example/vendor/
+example_old/vendor/
 
 # node.js
 #
@@ -62,6 +64,8 @@ android/keystores/debug.keystore
 
 # Expo
 .expo/
+example-expo/ios/
+example-expo/android/
 
 # Turborepo
 .turbo/

.nvmrc

@@ -1 +1 @@
-v18
+v20

.ruby-version

@@ -0,0 +1 @@
+3.1.0

android/build.gradle

@@ -60,6 +60,17 @@ android {
     }
   }
 
+  // Include arch-specific source sets
+  sourceSets {
+    main {
+      if (isNewArchitectureEnabled()) {
+        java.srcDirs += "src/newarch"
+      } else {
+        java.srcDirs += "src/oldarch"
+      }
+    }
+  }
+
   compileSdkVersion getExtOrIntegerDefault("compileSdkVersion")
 
   defaultConfig {

android/src/main/java/com/elementary/ElementaryModule.kt

@@ -4,6 +4,8 @@ import com.facebook.react.bridge.ReactApplicationContext
 import com.facebook.react.bridge.ReactContextBaseJavaModule
 import com.facebook.react.bridge.ReactMethod
 import com.facebook.react.bridge.Promise
+import com.facebook.react.bridge.WritableMap
+import com.facebook.react.modules.core.DeviceEventManagerModule
 
 class ElementaryModule(reactContext: ReactApplicationContext) :
   ReactContextBaseJavaModule(reactContext) {
@@ -13,15 +15,36 @@ class ElementaryModule(reactContext: ReactApplicationContext) :
   }
 
   @ReactMethod
-  fun getSampleRate(number: Double, promise: Promise) {
+  fun getSampleRate(promise: Promise) {
     promise.resolve(nativeGetSampleRate())
   }
 
-    @ReactMethod
+  @ReactMethod
   fun applyInstructions(message: String) {
     nativeApplyInstructions(message)
   }
 
+  @ReactMethod
+  fun addListener(eventName: String) {
+    // No-op, RN handles subscription tracking
+  }
+
+  @ReactMethod
+  fun removeListeners(count: Double) {
+    // No-op
+  }
+
+  // Helper to emit events
+  private fun sendEvent(eventName: String, params: WritableMap?) {
+    reactApplicationContext
+      .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter::class.java)
+      .emit(eventName, params)
+  }
+
+  fun emitAudioPlaybackFinished() {
+    sendEvent("AudioPlaybackFinished", null)
+  }
+
   companion object {
     const val NAME = "Elementary"
   }

android/src/newarch/com/elementary/ElementaryTurboModule.java

@@ -0,0 +1,35 @@
+package com.elementary;
+
+import androidx.annotation.NonNull;
+import com.facebook.react.bridge.ReactApplicationContext;
+import com.facebook.react.bridge.Promise;
+import com.elementary.NativeElementarySpec;
+
+public class ElementaryTurboModule extends NativeElementarySpec {
+    private final ElementaryModule module;
+
+    public ElementaryTurboModule(ReactApplicationContext reactContext) {
+        super(reactContext);
+        module = new ElementaryModule(reactContext);
+    }
+
+    @Override
+    public void getSampleRate(Promise promise) {
+        module.getSampleRate(promise);
+    }
+
+    @Override
+    public void applyInstructions(String message) {
+        module.applyInstructions(message);
+    }
+
+    @Override
+    public void addListener(String eventName) {
+        module.addListener(eventName);
+    }
+
+    @Override
+    public void removeListeners(double count) {
+        module.removeListeners(count);
+    }
+} 

android/src/newarch/com/elementary/ElementaryTurboPackage.java

@@ -0,0 +1,43 @@
+package com.elementary;
+
+import androidx.annotation.Nullable;
+import com.facebook.react.bridge.NativeModule;
+import com.facebook.react.bridge.ReactApplicationContext;
+import com.facebook.react.module.model.ReactModuleInfo;
+import com.facebook.react.module.model.ReactModuleInfoProvider;
+import com.facebook.react.TurboReactPackage;
+
+import java.util.HashMap;
+import java.util.Map;
+
+public class ElementaryTurboPackage extends TurboReactPackage {
+    @Nullable
+    @Override
+    public NativeModule getModule(String name, ReactApplicationContext reactContext) {
+        if (name.equals(ElementaryModule.NAME)) {
+            return new ElementaryTurboModule(reactContext);
+        } else {
+            return null;
+        }
+    }
+
+    @Override
+    public ReactModuleInfoProvider getReactModuleInfoProvider() {
+        return () -> {
+            final Map<String, ReactModuleInfo> moduleInfos = new HashMap<>();
+            moduleInfos.put(
+                ElementaryModule.NAME,
+                new ReactModuleInfo(
+                    ElementaryModule.NAME,
+                    ElementaryModule.NAME,
+                    false, // canOverrideExistingModule
+                    false, // needsEagerInit
+                    true,  // hasConstants
+                    false, // isCxxModule
+                    true   // isTurboModule
+                )
+            );
+            return moduleInfos;
+        };
+    }
+} 

android/src/oldarch/com/elementary/ElementaryTurboPackage.java

@@ -0,0 +1,27 @@
+package com.elementary;
+
+import androidx.annotation.NonNull;
+import com.facebook.react.ReactPackage;
+import com.facebook.react.bridge.NativeModule;
+import com.facebook.react.bridge.ReactApplicationContext;
+import com.facebook.react.uimanager.ViewManager;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+public class ElementaryTurboPackage implements ReactPackage {
+    @NonNull
+    @Override
+    public List<NativeModule> createNativeModules(@NonNull ReactApplicationContext reactContext) {
+        List<NativeModule> modules = new ArrayList<>();
+        modules.add(new ElementaryModule(reactContext));
+        return modules;
+    }
+
+    @NonNull
+    @Override
+    public List<ViewManager> createViewManagers(@NonNull ReactApplicationContext reactContext) {
+        return Collections.emptyList();
+    }
+}