Skip to content

Commit 355d3cd

Browse files
targosbnoordhuis
andcommitted
deps: V8: fix cppgc/heap.h for MSVC
Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>
1 parent 6ed7630 commit 355d3cd

2 files changed

Lines changed: 2 additions & 9 deletions

File tree

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.9',
39+
'v8_embedder_string': '-node.10',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/cppgc/heap.h

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -111,13 +111,6 @@ class V8_EXPORT Heap {
111111
* heap through `Heap::Create()`.
112112
*/
113113
struct HeapOptions {
114-
/**
115-
* Creates reasonable defaults for instantiating a Heap.
116-
*
117-
* \returns the HeapOptions that can be passed to `Heap::Create()`.
118-
*/
119-
static HeapOptions Default() { return {}; }
120-
121114
/**
122115
* Custom spaces added to heap are required to have indices forming a
123116
* numbered sequence starting at 0, i.e., their `kSpaceIndex` must
@@ -161,7 +154,7 @@ class V8_EXPORT Heap {
161154
*/
162155
static std::unique_ptr<Heap> Create(
163156
std::shared_ptr<Platform> platform,
164-
HeapOptions options = HeapOptions::Default());
157+
HeapOptions options = {});
165158

166159
virtual ~Heap() = default;
167160

0 commit comments

Comments
 (0)