Skip to content

Commit 1e7ac28

Browse files
authored
feat!: remove the ability to send completely raw bytes via grpc (#7117)
Description --- Changes the transfer command, that if you provide the raw bytes, it puts it into the open format. This does change legacy behaviour, but most people who use this are not aware that the bytes if provided in raw from need to contain some other details as well. By providing raw data to the wallet it thinks its i nthe correct form, but its not and this leads to weird looking payment id's <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Transaction details now include comprehensive input and output commitment data for enhanced transparency. - Transaction responses in transfers and batch processes provide enriched metadata for better insight. - **Refactor** - Improved payment ID construction during transfers for more precise transaction identification. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 8c97103 commit 1e7ac28

File tree

3 files changed

+370
-112
lines changed

3 files changed

+370
-112
lines changed

applications/minotari_app_grpc/proto/wallet.proto

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,6 +1151,7 @@ message TransferResult {
11511151
uint64 transaction_id = 2;
11521152
bool is_success = 3;
11531153
string failure_message = 4;
1154+
TransactionInfo transaction_info = 5;
11541155
}
11551156

11561157
message ClaimShaAtomicSwapRequest{
@@ -1194,6 +1195,8 @@ message TransactionInfo {
11941195
bytes raw_payment_id = 12;
11951196
uint64 mined_in_block_height = 13;
11961197
bytes user_payment_id = 14;
1198+
repeated bytes input_commitments = 15;
1199+
repeated bytes output_commitments = 16;
11971200
}
11981201

11991202
enum TransactionDirection {

0 commit comments

Comments
 (0)