code rabbit

Author: SWvheerden

applications/minotari_app_grpc/proto/base_node.proto

@@ -593,16 +593,3 @@ message PaymentReferenceResponse {
     optional uint64 revealed_amount = 9;
 }
 
-
-// Status of payment reference lookup
-enum PaymentReferenceStatus {
-    // Payment reference was found and confirmed
-    FOUND = 0;
-    // Payment reference was not found in the blockchain
-    NOT_FOUND = 1;
-    // Payment reference format is invalid
-    INVALID_FORMAT = 2;
-    // Payment reference is in mempool (unconfirmed)
-    PENDING = 3;
-}
-

applications/minotari_app_grpc/proto/wallet.proto

@@ -1580,15 +1580,3 @@ enum PaymentDirection {
   // Payment sent from this wallet
   PAYMENT_DIRECTION_OUTBOUND = 2;
 }
-
-// Enum for PayRef status indicating availability
-enum PayRefStatus {
-  // Unknown or unspecified status
-  PAYREF_STATUS_UNKNOWN = 0;
-  // PayRef is available (has sufficient confirmations)
-  PAYREF_STATUS_AVAILABLE = 1;
-  // PayRef is pending (waiting for more confirmations)
-  PAYREF_STATUS_PENDING = 2;
-  // PayRef is not mined (transaction not yet in a block)
-  PAYREF_STATUS_NOT_MINED = 3;
-}

base_layer/wallet/src/transaction_service/payment_reference.rs

@@ -69,19 +69,6 @@ pub enum PayRefDisplayFormat {
     Custom { prefix_chars: u8, suffix_chars: u8 },
 }
 
-/// Status of a Payment Reference
-#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
-pub enum PayRefStatus {
-    /// PayRef is available with the specified number of confirmations
-    Available(FixedHash, u64),
-    /// PayRef is pending more confirmations
-    Pending(u64, u64), // current_confirmations, blocks_remaining
-    /// Output has not been mined yet
-    NotMined,
-    /// Output data is invalid for PayRef generation
-    InvalidOutput,
-}
-
 /// Direction of a payment
 #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
 pub enum PaymentDirection {

base_layer/wallet/src/transaction_service/storage/sqlite_db.rs

@@ -1168,7 +1168,7 @@ impl TransactionBackend for TransactionServiceSqliteDatabase {
         let mut conn = self.database_connection.get_pooled_connection()?;
         let cipher = acquire_read_lock!(self.cipher);
 
-        let payref = PayrefSql::find_by_output_hash(&payref.to_vec(), &mut conn)?;
+        let payref = PayrefSql::find_by_payref(&payref.to_vec(), &mut conn)?;
         if payref.is_none() {
             return Ok(None);
         }
@@ -2474,12 +2474,12 @@ impl PayrefSql {
         Ok(())
     }
 
-    pub fn find_by_output_hash(
-        output_hash: &[u8],
+    pub fn find_by_payref(
+        payref: &[u8],
         conn: &mut SqliteConnection,
     ) -> Result<Option<PayrefSql>, TransactionStorageError> {
         let result = payrefs::table
-            .filter(payrefs::output_hash.eq(output_hash))
+            .filter(payrefs::payref.eq(payref))
             .first::<PayrefSql>(conn)
             .optional()?;
         Ok(result)