refactor: wrap set_as_unmined in a diesel transaction

Wrap the entire set_as_unmined body in conn.transaction() so that the
status update, payref archival, and payref deletion all happen
atomically. If any step fails, the entire operation rolls back.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: SWvheerden

base_layer/wallet/src/transaction_service/storage/sqlite_db.rs

@@ -2424,20 +2424,23 @@ impl CompletedTransactionSql {
     }
 
     pub fn set_as_unmined(tx_id: TxId, conn: &mut SqliteConnection) -> Result<(), TransactionStorageError> {
-        // First, get the existing transaction
-        let existing_tx = completed_transactions::table
-            .filter(completed_transactions::tx_id.eq(tx_id.as_u64() as i64))
-            .first::<CompletedTransactionSql>(conn)?;
+        conn.transaction::<_, TransactionStorageError, _>(|conn| {
+            // First, get the existing transaction
+            let existing_tx = completed_transactions::table
+                .filter(completed_transactions::tx_id.eq(tx_id.as_u64() as i64))
+                .first::<CompletedTransactionSql>(conn)?;
 
-        let (current_status, current_mined_height) = *completed_transactions::table
-            .filter(completed_transactions::tx_id.eq(tx_id.as_u64() as i64))
-            .select((completed_transactions::status, completed_transactions::mined_height))
-            .load::<(i32, Option<i64>)>(conn)?
-            .first()
-            .ok_or(TransactionStorageError::DieselError(DieselError::NotFound))?;
-        let current_status = LegacyTransactionStatus::try_from(current_status)
-            .map_err(|_| TransactionStorageError::UnexpectedResult("Unknown status".to_string()))?;
-        diesel::update(completed_transactions::table.filter(completed_transactions::tx_id.eq(tx_id.as_u64() as i64)))
+            let (current_status, current_mined_height) = *completed_transactions::table
+                .filter(completed_transactions::tx_id.eq(tx_id.as_u64() as i64))
+                .select((completed_transactions::status, completed_transactions::mined_height))
+                .load::<(i32, Option<i64>)>(conn)?
+                .first()
+                .ok_or(TransactionStorageError::DieselError(DieselError::NotFound))?;
+            let current_status = LegacyTransactionStatus::try_from(current_status)
+                .map_err(|_| TransactionStorageError::UnexpectedResult("Unknown status".to_string()))?;
+            diesel::update(
+                completed_transactions::table.filter(completed_transactions::tx_id.eq(tx_id.as_u64() as i64)),
+            )
             .set(UpdateCompletedTransactionSql {
                 status: match current_status {
                     LegacyTransactionStatus::OneSidedConfirmed | LegacyTransactionStatus::OneSidedUnconfirmed => {
@@ -2468,36 +2471,37 @@ impl CompletedTransactionSql {
             .execute(conn)
             .num_rows_affected_or_not_found(1)?;
 
-        // Archive existing payrefs to history before deleting, so that
-        // PayRefs from before a reorg can still be looked up.
-        let existing_payrefs = PayrefSql::find_all_by_tx_id(tx_id, conn)?;
-        for pr in &existing_payrefs {
-            PayrefHistorySql::archive_from_payref(pr, conn)?;
-        }
+            // Archive existing payrefs to history before deleting, so that
+            // PayRefs from before a reorg can still be looked up.
+            let existing_payrefs = PayrefSql::find_all_by_tx_id(tx_id, conn)?;
+            for pr in &existing_payrefs {
+                PayrefHistorySql::archive_from_payref(pr, conn)?;
+            }
 
-        let sent = match existing_tx.sent_output_hashes.as_ref() {
-            Some(bytes) => bytes_to_fixedhash_vec(bytes),
-            _ => vec![],
-        };
-        for output in sent {
-            PayrefSql::delete(output.as_ref(), conn)?;
-        }
-        let received = match existing_tx.received_output_hashes.as_ref() {
-            Some(bytes) => bytes_to_fixedhash_vec(bytes),
-            _ => vec![],
-        };
-        for output in received {
-            PayrefSql::delete(output.as_ref(), conn)?;
-        }
-        let change = match existing_tx.change_output_hashes.as_ref() {
-            Some(bytes) => bytes_to_fixedhash_vec(bytes),
-            _ => vec![],
-        };
-        for output in change {
-            PayrefSql::delete(output.as_ref(), conn)?;
-        }
+            let sent = match existing_tx.sent_output_hashes.as_ref() {
+                Some(bytes) => bytes_to_fixedhash_vec(bytes),
+                _ => vec![],
+            };
+            for output in sent {
+                PayrefSql::delete(output.as_ref(), conn)?;
+            }
+            let received = match existing_tx.received_output_hashes.as_ref() {
+                Some(bytes) => bytes_to_fixedhash_vec(bytes),
+                _ => vec![],
+            };
+            for output in received {
+                PayrefSql::delete(output.as_ref(), conn)?;
+            }
+            let change = match existing_tx.change_output_hashes.as_ref() {
+                Some(bytes) => bytes_to_fixedhash_vec(bytes),
+                _ => vec![],
+            };
+            for output in change {
+                PayrefSql::delete(output.as_ref(), conn)?;
+            }
 
-        Ok(())
+            Ok(())
+        })
     }
 
     #[allow(dead_code)]