fix: ledger builds (#7260)

Description
---
Fixed ledger builds locally using the latest ledger docker image;
however, the objective is to fix the ledger wallet auto-builds in
GitHub, and this may still need some tweaks in follow-up commits.

Motivation and Context
---
Ledger auto-builds in GitHub were failing.

How Has This Been Tested?
---
- Tested locally.
- Ledger auto-builds in GitHub:
https://github.com/hansieodendaal/tari/actions/runs/15869532430

![image](https://github.com/user-attachments/assets/28f139a7-291f-417c-90a9-4751204ed9a8)


What process can a PR reviewer use to test or verify this change?
---
Code review.
Check GitHub actions output.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Documentation**
- Updated the README to clarify installation instructions, specify the
correct working directory, and standardize path formatting for commands.

- **Refactor**
- Improved internal handling of string values for "Amount" and
"Receiver" fields to ensure data safety, with no change to visible
behavior.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: hansieodendaal

applications/minotari_ledger_wallet/wallet/README.md

@@ -145,16 +145,19 @@ ledgerctl delete "MinoTari Wallet"
 
 - Installation
 
+The following command has to be run from the root of the Tari ledger wallet repository, i.e. 
+`<TARI>/applications/minotari_ledger_wallet/wallet`.
+
 First locate `app_nanosplus.json`. It will either be in the ledger wallet root
-`/applications/minotari_ledger_wallet/wallet` or in its the target directory `./target/nanosplus/release`,
+`<TARI>/applications/minotari_ledger_wallet/wallet` or in its the target directory `./target/nanosplus/release`,
 then run one of the following commands to install the application:
 
 ```
 ledgerctl install app_nanosplus.json
 ```
 ```
-ledgerctl install .\target\nanosplus\release\app_nanosplus.json
-ledgerctl install .\target\stax\release\app_stax.json
+ledgerctl install ./target/nanosplus/release/app_nanosplus.json
+ledgerctl install ./target/stax/release/app_stax.json
 ```
 
 **Notes for Windows users:**

applications/minotari_ledger_wallet/wallet/src/crypto/hashing.rs

@@ -1,7 +1,6 @@
 // Copyright 2025 The Tari Project
 // SPDX-License-Identifier: BSD-3-Clause
 use alloc::{format, string::String};
-
 use core::marker::PhantomData;
 
 use digest::{Digest, FixedOutput, FixedOutputReset, Output, OutputSizeUser, Update};

applications/minotari_ledger_wallet/wallet/src/crypto/schnorr.rs

@@ -14,12 +14,12 @@ use rand_core::{CryptoRng, RngCore};
 use tari_utilities::ByteArray;
 
 use crate::{
-    hash_domain,
-    hashing::DomainSeparatedHash,
     crypto::{
         hashing::{DomainSeparatedHasher, DomainSeparation},
         keys::{RistrettoPublicKey, RistrettoSecretKey},
     },
+    hash_domain,
+    hashing::DomainSeparatedHash,
 };
 
 hash_domain!(SchnorrSigChallenge, "com.tari.schnorr_signature", 1);

applications/minotari_ledger_wallet/wallet/src/handlers/get_one_sided_metadata_signature.rs

@@ -20,25 +20,25 @@ use ledger_device_sdk::ui::{
     gadgets::{Field, MultiFieldReview, SingleMessage},
 };
 use minotari_ledger_wallet_common::{
-    get_public_spend_key_bytes_from_tari_dual_address,
     get_payment_id_bytes_from_tari_dual_address,
+    get_public_spend_key_bytes_from_tari_dual_address,
     tari_dual_address_display,
-    TARI_DUAL_ADDRESS_MIN_SIZE,
     TARI_DUAL_ADDRESS_MAX_SIZE,
+    TARI_DUAL_ADDRESS_MIN_SIZE,
 };
 use tari_utilities::ByteArray;
 use zeroize::Zeroizing;
 
 use crate::{
     alloc::string::ToString,
-    hashing::DomainSeparatedConsensusHasher,
     crypto::{
         commitment::PedersenCommitment,
         commitment_and_public_key_signature::CommitmentAndPublicKeySignature,
         commitment_factory::PedersenCommitmentFactory,
         hashing::DomainSeparatedHasher,
         keys::{RistrettoPublicKey, RistrettoSecretKey},
     },
+    hashing::DomainSeparatedConsensusHasher,
     utils::{
         derive_from_bip32_key,
         get_key_from_canonical_bytes,
@@ -56,7 +56,8 @@ pub fn handler_get_one_sided_metadata_signature(comm: &mut Comm) -> Result<(), A
     let data = comm.get_data().map_err(|_| AppSW::WrongApduLength)?;
 
     // Validate minimum required data size early
-    // Minimum: account(8) + network(8) + txo_version(8) + sender_offset_key_index(8) + value(8) + commitment_mask(32) + address_size(2) + min_address(67) + message(32) = 171
+    // Minimum: account(8) + network(8) + txo_version(8) + sender_offset_key_index(8) + value(8) + commitment_mask(32) +
+    // address_size(2) + min_address(67) + message(32) = 171
     if data.len() < 171 {
         return Err(AppSW::WrongApduLength);
     }
@@ -88,7 +89,7 @@ pub fn handler_get_one_sided_metadata_signature(comm: &mut Comm) -> Result<(), A
     if data.len() < 74 {
         return Err(AppSW::WrongApduLength);
     }
-    let address_size_bytes = &data[72..74]; 
+    let address_size_bytes = &data[72..74];
     let address_size = u16::from_le_bytes([address_size_bytes[0], address_size_bytes[1]]) as usize;
 
     if address_size < TARI_DUAL_ADDRESS_MIN_SIZE || address_size > TARI_DUAL_ADDRESS_MAX_SIZE {
@@ -126,20 +127,23 @@ pub fn handler_get_one_sided_metadata_signature(comm: &mut Comm) -> Result<(), A
         return Err(AppSW::WrongApduLength);
     }
     let mut metadata_signature_message_common = [0u8; 32];
-    metadata_signature_message_common.clone_from_slice(&data[metadata_signature_message_common_start..metadata_signature_message_common_end]);
+    metadata_signature_message_common
+        .clone_from_slice(&data[metadata_signature_message_common_start..metadata_signature_message_common_end]);
 
     // Extract payment ID if present
     let payment_id_bytes = get_payment_id_bytes_from_tari_dual_address(receiver_address_bytes)
         .map_err(|_| AppSW::MetadataSignatureFail)?;
 
     let mut fields = Vec::new();
+    let field_value = format!("{}", value.to_string());
     fields.push(Field {
         name: "Amount",
-        value: &format!("{}", value.to_string()),
+        value: &field_value,
     });
+    let field_value = format!("{}", receiver_address);
     fields.push(Field {
         name: "Receiver",
-        value: &format!("{}", receiver_address),
+        value: &field_value,
     });
 
     // Add payment ID field if present

applications/minotari_ledger_wallet/wallet/src/handlers/get_schnorr_signature.rs

@@ -12,8 +12,8 @@ use tari_utilities::ByteArray;
 
 use crate::{
     alloc::string::ToString,
-    hash_domain,
     crypto::schnorr::SchnorrSignature,
+    hash_domain,
     utils::{derive_from_bip32_key, get_random_nonce},
     AppSW,
     KeyType,

applications/minotari_ledger_wallet/wallet/src/handlers/get_script_signature.rs

@@ -13,13 +13,13 @@ use ledger_device_sdk::ui::gadgets::SingleMessage;
 
 use crate::{
     alloc::string::ToString,
-    hashing::DomainSeparatedConsensusHasher,
     crypto::{
         commitment::PedersenCommitment,
         commitment_and_public_key_signature::CommitmentAndPublicKeySignature,
         commitment_factory::PedersenCommitmentFactory,
         keys::{RistrettoPublicKey, RistrettoSecretKey},
     },
+    hashing::DomainSeparatedConsensusHasher,
     utils::{
         alpha_hasher,
         derive_from_bip32_key,

applications/minotari_ledger_wallet/wallet/src/main.rs

@@ -6,8 +6,8 @@
 #![feature(alloc_error_handler)]
 
 extern crate alloc;
-mod hashing;
 mod crypto;
+mod hashing;
 pub mod utils;
 
 mod app_ui {

applications/minotari_ledger_wallet/wallet/src/utils.rs

@@ -20,8 +20,8 @@ use zeroize::Zeroizing;
 
 use crate::{
     alloc::string::{String, ToString},
-    hash_domain,
     crypto::{hashing::DomainSeparatedHasher, keys::RistrettoSecretKey},
+    hash_domain,
     AppSW,
     KeyType,
     BIP32_COIN_TYPE,
@@ -164,9 +164,7 @@ fn get_raw_bip32_key(path: &[u32]) -> Result<Zeroizing<[u8; 64]>, String> {
                 Ok(key_buffer)
             }
         },
-        Err(e) => {
-            return Err(cx_error_to_string(e))
-        },
+        Err(e) => return Err(cx_error_to_string(e)),
     }
 }