fix: wallet sender details from sent transaction

[SWvheerden]

Description

Fill in the correct 1-sided address, and not interactive as the wallet may not be able to receive interactive.

Summary by CodeRabbit

• Bug Fixes
  • Updated the way sender addresses are associated with payment IDs for one-sided or stealth transactions, improving the accuracy of sender information in these transaction types.
  • Refined the construction of one-sided addresses to enhance transaction handling consistency.

[coderabbitai]

Walkthrough

The change updates the construction of the one-sided Tari address to use the spend_key.pub_key instead of the comms_key.pub_key in both the transaction service and output manager service. It also modifies the payment ID augmentation in the send_one_sided_or_stealth function to embed the one_sided_tari_address as the sender address when the payment ID is open or empty. No other logic or function signatures are affected.

Changes

File(s)	Change Summary
base_layer/wallet/src/transaction_service/service.rs	Updated one-sided Tari address construction to use spend_key.pub_key; changed payment ID sender address from interactive_tari_address to one_sided_tari_address in one-sided or stealth transactions.
base_layer/wallet/src/output_manager_service/service.rs	Modified one-sided Tari address construction in OutputManagerService::new to use spend_key.pub_key instead of comms_key.pub_key.

Poem

A hop and a skip, a new path to send,
One-sided addresses now help messages blend.
Payment IDs crafted with care and with cheer,
For stealthy transactions, the logic is clear.
The interactive route takes a rest for today,
As one-sided bunnies now lead the way! 🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 8e48c90 and 56a9624.

📒 Files selected for processing (1)

• base_layer/wallet/src/output_manager_service/service.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: test (mainnet, stagenet)
• GitHub Check: test (testnet, esmeralda)
• GitHub Check: test (nextnet, nextnet)
• GitHub Check: cargo check with stable
• GitHub Check: ci

🔇 Additional comments (1)

base_layer/wallet/src/output_manager_service/service.rs (1)

169-170: Approve: Fixed one-sided address construction by using spend key instead of comms key.

This change correctly updates the one-sided Tari address construction to use the spend key's public key instead of the communications key. This ensures consistent address handling and prevents potential issues when receiving transactions.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Test Results (CI)

1 075 tests   1 071 ✅  12m 55s ⏱️
   30 suites      0 💤
    1 files        4 ❌

For more details on these failures, see this check.

Results for commit 56a9624.

♻️ This comment has been updated with latest results.

[github-actions]

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   2h 4m 22s ⏱️ + 2h 4m 22s
36 tests +36  28 ✅ +28  0 💤 ±0   8 ❌ + 8 
49 runs  +49  32 ✅ +32  0 💤 ±0  17 ❌ +17 

For more details on these failures, see this check.

Results for commit 56a9624. ± Comparison against base commit 8901bcb.

♻️ This comment has been updated with latest results.