fix: return min results

[SWvheerden]

Description

fixes gprc call network state to always return results even if all the algos are not enabled

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling when retrieving target difficulty for proof-of-work algorithms, ensuring the network state is returned even if some values cannot be determined.

[coderabbitai]

Warning

Rate limit exceeded

@SWvheerden has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 35 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 0dcbe2b and 95247c3.

📒 Files selected for processing (1)

• applications/minotari_node/src/grpc/base_node_grpc_server.rs (4 hunks)

Walkthrough

The change updates error handling in the get_network_state method of BaseNodeGrpcServer by replacing error returns when fetching target difficulties for three proof-of-work algorithms with a fallback to a minimum difficulty value. No changes are made to function signatures or other logic.

Changes

File(s)	Change Summary
applications/minotari_node/src/grpc/base_node_grpc_server.rs	Modified error handling in get_network_state to use Difficulty::min() as a fallback instead of returning errors. Explicitly imported Difficulty.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant BaseNodeGrpcServer
    participant DifficultyProvider

    Client->>BaseNodeGrpcServer: get_network_state()
    loop For each PoW algorithm (Sha3x, RandomXM, RandomXT)
        BaseNodeGrpcServer->>DifficultyProvider: get_target_difficulty_for_next_block()
        alt Success
            DifficultyProvider-->>BaseNodeGrpcServer: Difficulty
        else Failure
            BaseNodeGrpcServer-->>BaseNodeGrpcServer: Use Difficulty::min()
        end
    end
    BaseNodeGrpcServer->>Client: NetworkStateResponse

Loading

Possibly related PRs

• fix: base node panic #7074: Modifies estimated hash rate calculation logic in the same get_network_state method, affecting a different aspect of the function.

Poem

A hiccup in difficulty, now caught with a grin,
No more errors returned, just a minimum spin.
The network keeps humming, the hashes still flow,
With fallback in place, onward we go!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.