fix: exclude coinbases from fee calc

[SWvheerden]

Description

dont include the coinbase in the fee calcs

Summary by CodeRabbit

• Bug Fixes
  • Corrected block fee calculations to exclude coinbase transactions, ensuring only non-coinbase fees are included.

[coderabbitai]

Walkthrough

The block_fees function in the block gRPC module was updated to exclude coinbase kernels when calculating total fees. The logic now filters out coinbase kernels, summing fees only from non-coinbase kernels. No changes were made to function signatures or public APIs.

Changes

File(s)	Change Summary
applications/minotari_node/src/grpc/blocks.rs	Updated block_fees to exclude coinbase kernels from fee calculation; internal logic change only

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Block
    participant Kernel

    Caller->>Block: Get block body
    Block->>Kernel: Iterate kernels
    Kernel-->>Block: Return is_coinbase() and fee
    Block->>Block: Filter out coinbase kernels
    Block->>Block: Sum fees of non-coinbase kernels
    Block-->>Caller: Return total fees

Loading

Possibly related PRs

• fix: force coinbase fee = 0 #6954: Enforces that coinbase kernels must have zero fees during validation, which is related to the exclusion of coinbase kernels from fee calculations.

Suggested reviewers

• hansieodendaal

Poem

In the ledger’s gentle breeze,
Rabbits count the fees with ease.
No coinbase kernels in the sum,
Only honest fees become
The total tallied for the block—
Hippity-hop, the code will rock! 🥕

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a6fa94 and df7e252.

📒 Files selected for processing (1)

• applications/minotari_node/src/grpc/blocks.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: Cucumber tests / FFI
• GitHub Check: Cucumber tests / Base Layer
• GitHub Check: test (mainnet, stagenet)
• GitHub Check: test (testnet, esmeralda)
• GitHub Check: test (nextnet, nextnet)
• GitHub Check: cargo check with stable
• GitHub Check: ci

🔇 Additional comments (1)

applications/minotari_node/src/grpc/blocks.rs (1)

76-85:

Details

✅ Verification successful

LGTM! Correctly excludes coinbase kernels from fee calculation.

The addition of the filter to exclude coinbase kernels is the correct approach for fee calculations in blockchain systems. Coinbase transactions represent miner rewards rather than user transaction fees, so they should not be included in the total fee calculation.

Let me verify that this behavioral change doesn't break any dependent code:

---

🏁 Script executed:

#!/bin/bash
# Description: Search for usages of block_fees function to ensure the behavioral change won't break existing functionality
# Expected: Find all usages and verify they expect fees excluding coinbase

echo "=== Searching for block_fees function usage ==="
rg -A 3 -B 3 "block_fees"

echo "=== Searching for any tests related to block_fees ==="
rg -A 5 -B 5 "block_fees.*test|test.*block_fees"

echo "=== Searching for fee-related calculations that might be affected ==="
rg -A 3 -B 3 "fee.*calculation|calculate.*fee"

Length of output: 30937

---

Approve block_fees update: excluding coinbase kernels is correct and safe

• block_fees is only used in base_node_grpc_server.rs for the GetBlockFees RPC and now properly returns user-paid fees (coinbase kernels are rewards).
• No tests reference block_fees, and existing fee-calculation code (Fee::calculate, calculate_coinbase_and_fees, calculate_fees) remains unchanged and unaffected.
• No dependent code expects coinbase fees to be included in the RPC response.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Test Results (CI)

    2 files     62 suites   22m 0s ⏱️
1 331 tests 1 325 ✅ 0 💤 6 ❌
1 770 runs  1 764 ✅ 0 💤 6 ❌

For more details on these failures, see this check.

Results for commit df7e252.

♻️ This comment has been updated with latest results.

[github-actions]

Test Results (Integration tests)

 2 files  11 suites   1h 44m 18s ⏱️
36 tests 18 ✅ 13 💤  5 ❌
45 runs  19 ✅ 13 💤 13 ❌

For more details on these failures, see this check.

Results for commit df7e252.

[hansieodendaal]

utACK