feat: add gprc methods to get fees by SWvheerden · Pull Request #7235 · tari-project/tari

SWvheerden · 2025-06-20T10:03:50Z

Description

Add grpc methods to get fee estimates for tx and mempool
Add user_payment_id to the transaction events

Fixes: #7093

Summary by CodeRabbit

New Features
- Added the ability to estimate transaction fees based on amount, fee per gram, and output count.
- Introduced a new feature to retrieve fee per gram statistics over recent blocks, including average, minimum, and maximum values.
Enhancements
- Improved transaction event details by distinguishing between raw and user-specific payment identifiers.

coderabbitai · 2025-06-20T10:03:56Z

"""

Walkthrough

The code introduces two new gRPC methods to the Wallet service for fee estimation and fee statistics. The proto definitions and server implementation are updated accordingly. The TransactionEvent message and related Rust code are modified to split the payment_id field into raw_payment_id and user_payment_id, enhancing payment ID handling.

Changes

File(s)	Change Summary
applications/minotari_app_grpc/proto/wallet.proto	Added `GetFeeEstimate` and `GetFeePerGramStats` RPCs; introduced new messages for fee estimation/stats; split `payment_id` into `raw_payment_id` and `user_payment_id` in `TransactionEvent`.
applications/minotari_console_wallet/src/grpc/wallet_grpc_server.rs	Implemented `get_fee_estimate` and `get_fee_per_gram_stats` gRPC methods; updated event handling for split payment IDs.
applications/minotari_console_wallet/src/grpc/mod.rs	Modified `convert_to_transaction_event` to split `payment_id` into `raw_payment_id` and `user_payment_id`.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant WalletGrpcServer
    participant OutputManagerService
    participant TransactionService

    Client->>WalletGrpcServer: GetFeeEstimate(request)
    WalletGrpcServer->>OutputManagerService: fee_estimate(amount, fee_per_gram, output_count)
    OutputManagerService-->>WalletGrpcServer: estimated_fee
    WalletGrpcServer-->>Client: GetFeeEstimateResponse(estimated_fee)

    Client->>WalletGrpcServer: GetFeePerGramStats(request)
    WalletGrpcServer->>TransactionService: get_fee_per_gram_stats_per_block(block_count)
    TransactionService-->>WalletGrpcServer: fee_per_gram_stats
    WalletGrpcServer-->>Client: GetFeePerGramStatsResponse(fee_per_gram_stats)

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Add fee estimate gRPC call (#7093)	✅

Assessment against linked issues: Out-of-scope changes

Code Change (file_path)	Explanation
Split `payment_id` into `raw_payment_id` and `user_payment_id` in `TransactionEvent` (wallet.proto, wallet_grpc_server.rs, mod.rs)	This change is unrelated to the fee estimate gRPC call and not mentioned in the linked issue.

Suggested reviewers

hansieodendaal

Poem

A hop, a skip, a fee to see—
New gRPC calls, as quick as can be!
With payment IDs now split in two,
Estimations and stats, all shiny and new.
The bunny approves, with a twitch of its nose,
For this wallet’s progress, the excitement grows!
🐇✨
"""

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3f6fbb2 and 6dc85db.

📒 Files selected for processing (2)

applications/minotari_console_wallet/src/grpc/mod.rs (3 hunks)
applications/minotari_console_wallet/src/grpc/wallet_grpc_server.rs (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

applications/minotari_console_wallet/src/grpc/mod.rs
applications/minotari_console_wallet/src/grpc/wallet_grpc_server.rs

⏰ Context from checks skipped due to timeout of 90000ms (7)

GitHub Check: test (mainnet, stagenet)
GitHub Check: test (testnet, esmeralda)
GitHub Check: test (nextnet, nextnet)
GitHub Check: cargo check with stable
GitHub Check: ci
GitHub Check: Cucumber tests / FFI
GitHub Check: Cucumber tests / Base Layer

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-06-20T10:15:02Z

Test Results (CI)

3 files 126 suites 39m 35s ⏱️
1 351 tests 1 351 ✅ 0 💤 0 ❌
4 051 runs 4 051 ✅ 0 💤 0 ❌

Results for commit 6dc85db.

♻️ This comment has been updated with latest results.

github-actions · 2025-06-20T10:34:43Z

Test Results (Integration tests)

2 files 10 suites 1h 19m 52s ⏱️
30 tests 24 ✅ 1 💤 5 ❌
39 runs 25 ✅ 1 💤 13 ❌

For more details on these failures, see this check.

Results for commit 3f6fbb2.

hansieodendaal

See comments below

hansieodendaal · 2025-06-20T10:49:42Z

applications/minotari_console_wallet/src/grpc/mod.rs

+            raw_payment_id: vec![],
+            user_payment_id: vec![],


We could fill in payment id here as well

its not going to be correct, payment_id is only finalised when it reaches completed.

hansieodendaal · 2025-06-20T10:49:54Z

applications/minotari_console_wallet/src/grpc/mod.rs

+            raw_payment_id: vec![],
+            user_payment_id: vec![],


We could fill in payment id here as well

its not going to be correct, payment_id is only finalised when it reaches completed.

hansieodendaal · 2025-06-20T10:51:43Z

applications/minotari_console_wallet/src/grpc/wallet_grpc_server.rs

+                amount.into(),
+                selection_criteria,
+                fee_per_gram.into(),
+                1, // We assume 1 input for simplicity


We might as well provide the amount of ~~outputs~~ inputs here and to the request

outputs are below?

Read inputs

feat: add gprc methods to get fees

3f6fbb2

hansieodendaal reviewed Jun 20, 2025

View reviewed changes

review comments

6dc85db

SWvheerden merged commit 83969f3 into tari-project:development Jun 20, 2025
15 checks passed

SWvheerden deleted the sw_feat_grpc_imporve branch June 20, 2025 13:37

coderabbitai bot mentioned this pull request Nov 11, 2025

feat: increase fee estimate details #7579

Merged

Conversation

SWvheerden commented Jun 20, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results (CI)

Uh oh!

github-actions bot commented Jun 20, 2025

Test Results (Integration tests)

Uh oh!

hansieodendaal left a comment

Choose a reason for hiding this comment

Uh oh!

hansieodendaal Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

SWvheerden Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

hansieodendaal Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

SWvheerden Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

hansieodendaal Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SWvheerden Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

hansieodendaal Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

SWvheerden commented Jun 20, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jun 20, 2025 •

edited

Loading

hansieodendaal Jun 20, 2025 •

edited

Loading