ci: add clippy lint check for examples and fix existing warnings

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: sdbondi

.github/workflows/ci.yml

@@ -9,6 +9,31 @@ env:
   CARGO_TERM_COLOR: always
 
 jobs:
+  lint-examples:
+    name: Lint Examples
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: dtolnay/rust-toolchain@stable
+        with:
+          components: clippy
+          targets: wasm32-unknown-unknown
+
+      - uses: Swatinem/rust-cache@v2
+        with:
+          workspaces: |
+            examples/guessing_game/template
+            examples/guessing_game/cli
+
+      - name: Clippy (template - wasm)
+        working-directory: examples/guessing_game/template
+        run: cargo clippy --target wasm32-unknown-unknown -- -D warnings
+
+      - name: Clippy (cli)
+        working-directory: examples/guessing_game/cli
+        run: cargo clippy -- -D warnings
+
   test-templates:
     name: Test Templates
     runs-on: ubuntu-latest

examples/guessing_game/cli/src/main.rs

@@ -20,7 +20,7 @@ use tari_ootle_common_types::{Network, engine_types::transaction_receipt::Transa
 use tari_ootle_transaction::{TransactionBuilder, args};
 use tari_template_lib_types::{
     ComponentAddress, NonFungibleAddress, NonFungibleId, ResourceAddress, TemplateAddress,
-    constants::{TARI, TARI_TOKEN},
+    constants::{ TARI_TOKEN},
 };
 use tari_utilities::{ByteArray, hex::Hex};
 
@@ -357,7 +357,7 @@ async fn cmd_init(state_path: &Path, state: &mut State) -> anyhow::Result<()> {
     println!("  🏦 Account component: {account_addr}");
 
     let unsigned_tx = IFaucet::new(&provider)
-        .take_faucet_funds(10 * TARI)
+        .take_faucet_funds()
         .pay_fee(500u64)
         .prepare()
         .await?;
@@ -663,7 +663,7 @@ async fn create_user(
     state: &mut State,
     name_arg: Option<String>,
 ) -> anyhow::Result<()> {
-    let name = name_arg.unwrap_or_else(|| generate_name());
+    let name = name_arg.unwrap_or_else(generate_name);
     let network = parse_network(&state.network)?;
     let secret = OotleSecretKey::random(network);
     let wallet = OotleWallet::from(PrivateKeyProvider::new(secret.clone()));
@@ -679,7 +679,7 @@ async fn create_user(
     println!("👤 Creating user '{name}' with account address {account_address}...");
 
     let unsigned_tx = IFaucet::new(&provider)
-        .take_faucet_funds(10 * TARI)
+        .take_faucet_funds()
         .pay_fee(500u64)
         .prepare()
         .await?;
@@ -787,7 +787,7 @@ async fn cmd_end_game(state: &mut State) -> anyhow::Result<()> {
     }
     println!(
         "🏆 The number was {}.",
-        number.unwrap_or_else(|| "unknown?")
+        number.unwrap_or("unknown?")
     );
     println!("🏆 Round ended.");