Add basic zsh completion (issue #32)

[VorpalBlade]

This PR adds basic zsh completion. There are a couple of TODO comments I would like your feedback on in the file as well.

Note that I have only tested the basics using bfs 2.5 on Arch Linux (bfs installed using AUR and the completion file installed manually). If anything related to command line handling has changed since that release it will need to be incorporated here.

I have not at all tested the changes to the Makefile at all but they look straight forward.

[VorpalBlade]

I'm also not sure how -exclude works from the man page. It is possible that the completion that it needs a single argument is not correct.

[tavianator]

Thanks for this! :)

I'm also not sure how -exclude works from the man page. It is possible that the completion that it needs a single argument is not correct.

-exclude is an operator, like -not, that applies to the expression after it. So

$ bfs -exclude -name .git
$ bfs -exclude \( -name .git -o -name .svn \)

etc.

[tavianator]

Looks pretty good! I haven't reviewed it in detail yet, but so far all I've noticed is you should update make uninstall to match make install.

[VorpalBlade]

Done. Though I suggest people use a package manager rather than relying on make uninstall.

[tavianator]

Done. Though I suggest people use a package manager rather than relying on make uninstall.

Oh for sure! make install is mostly for the benefit of packagers themselves. make uninstall is for my benefit when I'm testing make install :)

(Btw your last patch has a whitespace error, the recipe needs to use a leading tab.)

Anyway I just tried this and it doesn't seem like zsh is using the completion. All I get are files. -<TAB> doesn't show anything. Any idea why?

[VorpalBlade]

(Btw your last patch has a whitespace error, the recipe needs to use a leading tab.)

Huh, vscode seems to be doing stupid things in Makefiles.

[tavianator]

I merged this manually as 7f37e41