fix: Improve SHA matching in repository status checks

Improved the logic for checking repository status by SHA. Previously, it
only checked if any status entry contained the target SHA. Now, it
verifies that a specific number of status entries match the target SHA,
providing a more robust check. Additionally, it was enhanced to report
all available SHAs if a matching SHA is not found, aiding in debugging.
This change ensures that tests accurately reflect the expected status
updates for a given commit.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

Author: chmouel

test/pkg/wait/check.go

@@ -47,14 +47,28 @@ func Succeeded(ctx context.Context, t *testing.T, runcnx *params.Run, opts optio
 	repo, err := runcnx.Clients.PipelineAsCode.PipelinesascodeV1alpha1().Repositories(sopt.TargetNS).Get(ctx, sopt.TargetNS, v1.GetOptions{})
 	assert.NilError(t, err)
 
+	assert.Assert(t, len(repo.Status) > 0, "repository status is empty")
 	laststatus := repo.Status[len(repo.Status)-1]
 	if sopt.SHA != "" {
+		found := false
 		for i := len(repo.Status) - 1; i >= 0; i-- {
 			if repo.Status[i].SHA != nil && *repo.Status[i].SHA == sopt.SHA {
 				laststatus = repo.Status[i]
+				found = true
 				break
 			}
 		}
+		if !found {
+			availableSHAs := make([]string, 0, len(repo.Status))
+			for _, st := range repo.Status {
+				if st.SHA != nil {
+					availableSHAs = append(availableSHAs, *st.SHA)
+				} else {
+					availableSHAs = append(availableSHAs, "<nil>")
+				}
+			}
+			assert.Assert(t, false, "no matching status found for SHA %s; available SHAs: %v", sopt.SHA, availableSHAs)
+		}
 	}
 	assert.Equal(t, corev1.ConditionTrue, laststatus.Conditions[0].Status)
 	if sopt.SHA != "" {

test/pkg/wait/wait.go

@@ -75,16 +75,13 @@ func UntilRepositoryUpdated(ctx context.Context, clients clients.Clients, opts O
 		clients.Log.Infof("Still waiting for repository status to be updated: %d/%d", len(repo.Status), opts.MinNumberStatus)
 		time.Sleep(2 * time.Second)
 		if opts.TargetSHA != "" {
-			hasSHAStatus := false
+			matchingStatuses := 0
 			for _, s := range repo.Status {
 				if s.SHA != nil && *s.SHA == opts.TargetSHA {
-					hasSHAStatus = true
-					break
+					matchingStatuses++
 				}
 			}
-			if !hasSHAStatus {
-				return false, nil
-			}
+			return matchingStatuses > 0 && len(repo.Status) >= opts.MinNumberStatus, nil
 		}
 		return len(repo.Status) >= opts.MinNumberStatus, nil
 	})