chore: replace real time.Sleep with clockwork in unit tests

Inject clockwork.FakeClock into Gitea and GitHub provider retry/backoff
loops so tests don't wait on real sleeps (~10s saved). Reduce LLM
timeout test mock sleeps from 2s to 200ms.

Fixes #2594

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

Author: chmouel

pkg/llm/providers/gemini/client_test.go

@@ -463,7 +463,7 @@ func TestAnalyzeTimeout(t *testing.T) {
 
 	client.httpClient = &http.Client{
 		Transport: httptesting.RoundTripFunc(func(_ *http.Request) *http.Response {
-			time.Sleep(2 * time.Second)
+			time.Sleep(200 * time.Millisecond)
 			return &http.Response{
 				StatusCode: http.StatusOK,
 				Body:       io.NopCloser(strings.NewReader("")),

pkg/llm/providers/openai/client_test.go

@@ -479,7 +479,7 @@ func TestAnalyzeTimeout(t *testing.T) {
 
 	client.httpClient = &http.Client{
 		Transport: httptesting.RoundTripFunc(func(_ *http.Request) *http.Response {
-			time.Sleep(2 * time.Second)
+			time.Sleep(200 * time.Millisecond)
 			return &http.Response{
 				StatusCode: http.StatusOK,
 				Body:       io.NopCloser(strings.NewReader("")),

pkg/provider/gitea/gitea.go

@@ -17,6 +17,7 @@ import (
 	"time"
 
 	"codeberg.org/mvdkleijn/forgejo-sdk/forgejo/v3"
+	"github.com/jonboulle/clockwork"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/apis/pipelinesascode/v1alpha1"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/changedfiles"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/events"
@@ -68,6 +69,7 @@ type Provider struct {
 	triggerEvent       string
 	pacUserID          int64 // user login used by PAC
 	cachedChangedFiles *changedfiles.ChangedFiles
+	clock              clockwork.Clock
 }
 
 func (v *Provider) Client() *forgejo.Client {
@@ -82,6 +84,13 @@ func (v *Provider) Client() *forgejo.Client {
 	return v.giteaClient
 }
 
+func (v *Provider) getClock() clockwork.Clock {
+	if v.clock == nil {
+		return clockwork.NewRealClock()
+	}
+	return v.clock
+}
+
 func (v *Provider) SetGiteaClient(client *forgejo.Client) {
 	v.giteaClient = client
 }
@@ -300,7 +309,7 @@ func (v *Provider) createStatusCommit(ctx context.Context, event *info.Event, pa
 			// Only retry on transient "user does not exist" errors
 			if strings.Contains(err.Error(), "user does not exist") {
 				v.Logger.Warnf("CreateStatus failed with transient error, retrying %d/%d: %v", i+1, maxRetries, err)
-				time.Sleep(time.Duration(i+1) * 500 * time.Millisecond)
+				v.getClock().Sleep(time.Duration(i+1) * 500 * time.Millisecond)
 				continue
 			}
 			return err

pkg/provider/gitea/gitea_test.go

@@ -15,6 +15,7 @@ import (
 	"time"
 
 	"github.com/google/go-cmp/cmp"
+	"github.com/jonboulle/clockwork"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/apis/pipelinesascode/v1alpha1"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/changedfiles"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/opscomments"
@@ -679,9 +680,11 @@ func TestProviderCreateStatusCommitRetryOnTransientError(t *testing.T) {
 				_, _ = rw.Write([]byte(`{"state":"success"}`))
 			})
 
+			fc := clockwork.NewFakeClock()
 			v := &Provider{
 				giteaClient: fakeclient,
 				Logger:      logger,
+				clock:       fc,
 			}
 
 			event := &info.Event{
@@ -696,7 +699,18 @@ func TestProviderCreateStatusCommitRetryOnTransientError(t *testing.T) {
 				Conclusion: "success",
 			}
 
-			err := v.createStatusCommit(context.Background(), event, pacopts, status)
+			ctx := context.Background()
+			if strings.Contains(tt.errorMessage, "user does not exist") && tt.failCount > 0 {
+				// Drive the fake clock only for retryable cases that actually sleep.
+				go func() {
+					for i := range 3 {
+						fc.BlockUntilContext(ctx, 1) //nolint:errcheck
+						fc.Advance(time.Duration(i+1) * 500 * time.Millisecond)
+					}
+				}()
+			}
+
+			err := v.createStatusCommit(ctx, event, pacopts, status)
 
 			if tt.wantErr {
 				assert.Assert(t, err != nil, "expected an error but got none")

pkg/provider/github/github.go

@@ -64,6 +64,7 @@ type Provider struct {
 	cachedChangedFiles *changedfiles.ChangedFiles
 	commitInfo         *github.Commit
 	pacUserLogin       string // user/bot login used by PAC
+	clock              clockwork.Clock
 }
 
 type skippedRun struct {
@@ -78,9 +79,17 @@ func New() *Provider {
 		skippedRun: skippedRun{
 			mutex: &sync.Mutex{},
 		},
+		clock: clockwork.NewRealClock(),
 	}
 }
 
+func (v *Provider) getClock() clockwork.Clock {
+	if v.clock == nil {
+		return clockwork.NewRealClock()
+	}
+	return v.clock
+}
+
 func (v *Provider) Client() *github.Client {
 	return v.ghClient
 }

pkg/provider/github/parse_payload.go

@@ -269,7 +269,7 @@ func (v *Provider) getPullRequestsWithCommit(ctx context.Context, sha, org, repo
 			select {
 			case <-ctx.Done():
 				return nil, ctx.Err()
-			case <-time.After(backoff):
+			case <-v.getClock().After(backoff):
 			}
 		}
 	}

pkg/provider/github/parse_payload_test.go

@@ -6,8 +6,10 @@ import (
 	"fmt"
 	"net/http"
 	"testing"
+	"time"
 
 	"github.com/google/go-github/v84/github"
+	"github.com/jonboulle/clockwork"
 	"gotest.tools/v3/assert"
 	"gotest.tools/v3/env"
 	corev1 "k8s.io/api/core/v1"
@@ -268,6 +270,18 @@ func TestGetPullRequestsWithCommit(t *testing.T) {
 				}
 			}
 
+			// Inject a fake clock for merge commit tests to avoid real backoff delays
+			if tt.isMergeCommit {
+				fc := clockwork.NewFakeClock()
+				provider.clock = fc
+				go func() {
+					for i := range maxRetriesForMergeCommit {
+						fc.BlockUntilContext(ctx, 1) //nolint:errcheck
+						fc.Advance(time.Duration(1<<uint(i)) * time.Second)
+					}
+				}()
+			}
+
 			prs, err := provider.getPullRequestsWithCommit(ctx, tt.sha, tt.org, tt.repo, tt.isMergeCommit)
 			assert.Equal(t, err != nil, tt.wantErr)
 			assert.Equal(t, len(prs), tt.wantPRsCount)