fix: TestGHEPullRequestGitopsCommentCancel race

The E2E test TestGithubGHEPullRequestGitopsCommentCancel in
test/github_pullrequest_retest_test.go:64 fails intermittently because
it uses the wrong wait strategy after issuing /cancel. The test uses
UntilRepositoryUpdated with MinNumberStatus: 3, which passes immediately
when there are already ≥3 repo statuses — before the cancel has taken
effect. The last status is then ConditionTrue (succeeded) instead of the
expected ConditionFalse (cancelled)

Reuse the same robust pattern that we already do in
test/github_push_retest_test.go:194-211, it does this:

1. Waits for the PipelineRun to have Cancelled reason via
   UntilPipelineRunHasReason
2. Then waits for the Repository status to have Cancelled reason via
   UntilRepositoryHasStatusReason
3. Falls back to checking controller logs if the cancel didn't propagate

Author: chmouel

test/github_pullrequest_retest_test.go

@@ -7,11 +7,13 @@ import (
 	"fmt"
 	"strings"
 	"testing"
+	"time"
 
 	"github.com/google/go-github/v84/github"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/apis/pipelinesascode/keys"
 	tgithub "github.com/openshift-pipelines/pipelines-as-code/test/pkg/github"
 	twait "github.com/openshift-pipelines/pipelines-as-code/test/pkg/wait"
+	tektonv1 "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1"
 	"gotest.tools/v3/assert"
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -98,21 +100,21 @@ func TestGithubGHEPullRequestGitopsCommentCancel(t *testing.T) {
 		&github.IssueComment{Body: github.Ptr("/cancel pr-gitops-comment")})
 	assert.NilError(t, err)
 
-	waitOpts = twait.Opts{
+	cancelWaitOpts := twait.Opts{
 		RepoName:        g.TargetNamespace,
 		Namespace:       g.TargetNamespace,
-		MinNumberStatus: 3,
-		PollTimeout:     twait.DefaultTimeout,
+		MinNumberStatus: 1,
+		PollTimeout:     90 * time.Second,
 		TargetSHA:       g.SHA,
 	}
-	g.Cnx.Clients.Log.Info("Waiting for Repository to be updated")
-	_, err = twait.UntilRepositoryUpdated(ctx, g.Cnx.Clients, waitOpts)
+
+	g.Cnx.Clients.Log.Info("Waiting for PipelineRun to be cancelled")
+	err = twait.UntilPipelineRunHasReason(ctx, g.Cnx.Clients, tektonv1.PipelineRunReasonCancelled, cancelWaitOpts)
 	assert.NilError(t, err)
 
-	g.Cnx.Clients.Log.Infof("Check if we have the repository set as succeeded")
-	repo, err := g.Cnx.Clients.PipelineAsCode.PipelinesascodeV1alpha1().Repositories(g.TargetNamespace).Get(ctx, g.TargetNamespace, metav1.GetOptions{})
+	g.Cnx.Clients.Log.Info("Waiting for Repository status to reflect cancellation")
+	_, err = twait.UntilRepositoryHasStatusReason(ctx, g.Cnx.Clients, cancelWaitOpts, tektonv1.PipelineRunReasonCancelled.String())
 	assert.NilError(t, err)
-	assert.Equal(t, repo.Status[len(repo.Status)-1].Conditions[0].Status, corev1.ConditionFalse)
 
 	pruns, err = g.Cnx.Clients.Tekton.TektonV1().PipelineRuns(g.TargetNamespace).List(ctx, metav1.ListOptions{
 		LabelSelector: fmt.Sprintf("%s=%s", keys.SHA, g.SHA),