fix: set PipelineURL for cached pipelines to resolve relative task paths

When multiple PipelineRuns reference the same remote pipeline with relative
task paths, the second PipelineRun fails because the PipelineURL is not set
when retrieving the pipeline from cache.

This causes assembleTaskFQDNs to receive an empty PipelineURL, which returns
relative paths unchanged (e.g., '../../common/tasks/hello.yaml'). The
go-github library then rejects these paths with 'path must not contain ..'
error.

The fix sets PipelineURL when using cached pipelines, ensuring relative task
paths are resolved correctly for all PipelineRuns.

Fixes: SRVKP-10604

Signed-off-by: Shubham Mathur <shumathu@redhat.com>

Author: mathur07

pkg/resolve/remote.go

@@ -129,9 +129,9 @@ func resolveRemoteResources(ctx context.Context, rt *matcher.RemoteTasks, types
 					}
 					// add the pipeline to the Resources fetched for the Event
 					fetchedResourcesForEvent.Pipelines[remotePipeline] = pipeline
-					// add the pipeline URL to the run specific Resources
-					fetchedResourcesForPipelineRun.PipelineURL = remotePipeline
 				}
+				// set the pipeline URL for relative task path resolution (used by both cached and newly fetched)
+				fetchedResourcesForPipelineRun.PipelineURL = remotePipeline
 			}
 		}
 		pipelineTasks := []string{}

pkg/resolve/remote_test.go

@@ -244,6 +244,53 @@ func TestRemote(t *testing.T) {
 				"remote-pipeline-with-relative-tasks-1.yaml",
 			},
 		},
+		{
+			name: "multiple pipelineruns sharing same remote pipeline with relative tasks, pipeline and tasks all resolve",
+			pipelineruns: []*tektonv1.PipelineRun{
+				ttkn.MakePR(randomPipelineRunName, map[string]string{
+					apipac.Pipeline: remotePipelineURL,
+				},
+					tektonv1.PipelineRunSpec{
+						PipelineRef: &tektonv1.PipelineRef{
+							Name: remotePipelineName,
+						},
+					},
+				),
+				ttkn.MakePR(randomPipelineRunName+"-second", map[string]string{
+					apipac.Pipeline: remotePipelineURL, // SAME URL as first PipelineRun
+				},
+					tektonv1.PipelineRunSpec{
+						PipelineRef: &tektonv1.PipelineRef{
+							Name: remotePipelineName,
+						},
+					},
+				),
+			},
+			remoteURLS: map[string]map[string]string{
+				remotePipelineURL: {
+					"body": string(pipelineWithRelativeTaskRefYamlB),
+					"code": "200",
+				},
+				remoteTaskURL + "-a": {
+					"body": string(singleRelativeTaskBa),
+					"code": "200",
+				},
+				remoteTaskURL + "-b": {
+					"body": string(singleRelativeTaskBb),
+					"code": "200",
+				},
+				remoteTaskURL + "-c": {
+					"body": string(singleRelativeTaskBc),
+					"code": "200",
+				},
+			},
+			expectedTaskSpec:     taskFromPipelineSpec,
+			expectedLogsSnippets: []string{},
+			expectedPipelineRun: []string{
+				"remote-pipeline-with-relative-tasks.yaml",
+				"remote-pipeline-with-relative-tasks-same-pipeline.yaml",
+			},
+		},
 		{
 			name: "remote pipeline with remote task in pipeline overridden from pipelinerun",
 			pipelineruns: []*tektonv1.PipelineRun{

pkg/resolve/testdata/remote-pipeline-with-relative-tasks-same-pipeline.yaml

@@ -0,0 +1,31 @@
+apiVersion: tekton.dev/v1
+kind: PipelineRun
+metadata:
+  annotations:
+    pipelinesascode.tekton.dev/pipeline: http://remote/remote-pipeline
+  generateName: pipelinerun-abc-second-
+spec:
+  pipelineSpec:
+    tasks:
+    - name: remote-task-a
+      taskSpec:
+        steps:
+        - name: step1
+          image: scratch
+          command:
+          - "true"
+    - name: remote-task-b
+      taskSpec:
+        steps:
+        - name: step1
+          image: scratch
+          command:
+          - "true"
+    - name: remote-task-c
+      taskSpec:
+        steps:
+        - name: step1
+          image: scratch
+          command:
+          - "true"
+    finally: []