test(ghe webhook): correct PLR count in regex marker test

Update TestGithubGHEWebhookCommentStrategyUpdateMarkerMatchingWithRegexChars
to expect 2 pipeline runs instead of 4, matching actual behavior.
Rename test data files to simpler names and update CEL expressions to
use proper event type checks instead of hardcoded "true".

Signed-off-by: Akshay Pant <akshay.akshaypant@gmail.com>

Author: theakshaypant

test/github_comment_strategy_update_test.go

@@ -244,16 +244,16 @@ func TestGithubGHEWebhookCommentStrategyUpdateMultiplePLRs(t *testing.T) {
 }
 
 // TestGithubCommentStrategyUpdateMarkerMatchingWithRegexChars tests:
-// 1. PLR names containing regex-relevant characters (dots, brackets, etc.) are handled correctly
+// 1. PLR names containing regex-relevant characters are handled correctly
 // 2. Marker matching remains exact even with special characters
 // 3. No cross-contamination between PLRs with similar names.
 func TestGithubGHEWebhookCommentStrategyUpdateMarkerMatchingWithRegexChars(t *testing.T) {
 	ctx := context.Background()
 	g := &tgithub.PRTest{
 		Label: "Github Comment Strategy Regex Chars",
 		YamlFiles: []string{
-			"testdata/pipelinerun-regex-chars-dots.yaml",
-			"testdata/pipelinerun-regex-chars-brackets.yaml",
+			"testdata/pipelinerun-regex-name.yaml",
+			"testdata/pipelinerun2-regex-name.yaml",
 		},
 		GHE:     true,
 		Webhook: true,
@@ -339,7 +339,7 @@ func TestGithubGHEWebhookCommentStrategyUpdateMarkerMatchingWithRegexChars(t *te
 	assert.NilError(t, err)
 	g.Cnx.Clients.Log.Infof("Pushed dummy commit: %s", sha)
 
-	sopt.NumberofPRMatch = 4
+	sopt.NumberofPRMatch = 2
 	sopt.SHA = sha
 	sopt.Title = "test: trigger comment update"
 	twait.Succeeded(ctx, t, g.Cnx, g.Options, sopt)

…stdata/pipelinerun-regex-chars-dots.yaml test/testdata/pipelinerun-regex-name.yamltest/testdata/pipelinerun-regex-chars-dots.yaml renamed to test/testdata/pipelinerun-regex-name.yaml test/testdata/pipelinerun-regex-chars-dots.yaml renamed to test/testdata/pipelinerun-regex-name.yaml

@@ -5,7 +5,7 @@ metadata:
   name: test.pipeline.v1.0
   annotations:
     pipelinesascode.tekton.dev/target-namespace: "\\ .TargetNamespace //"
-    pipelinesascode.tekton.dev/on-cel-expression: "true"
+    pipelinesascode.tekton.dev/on-cel-expression: event_type == "pull_request"
 spec:
   pipelineSpec:
     tasks:

…ta/pipelinerun-regex-chars-brackets.yaml …st/testdata/pipelinerun2-regex-name.yamltest/testdata/pipelinerun-regex-chars-brackets.yaml renamed to test/testdata/pipelinerun2-regex-name.yaml test/testdata/pipelinerun-regex-chars-brackets.yaml renamed to test/testdata/pipelinerun2-regex-name.yaml

@@ -2,10 +2,10 @@
 apiVersion: tekton.dev/v1beta1
 kind: PipelineRun
 metadata:
-  name: test-pipeline[0]
+  name: test.pipeline.v120
   annotations:
     pipelinesascode.tekton.dev/target-namespace: "\\ .TargetNamespace //"
-    pipelinesascode.tekton.dev/on-cel-expression: "true"
+    pipelinesascode.tekton.dev/on-cel-expression: event_type == "pull_request"
 spec:
   pipelineSpec:
     tasks: