fix: Increase log line count for tests

Increased the maximum number of log lines to check in various test
cases. This change was made to accommodate potentially longer log
outputs during test execution, preventing false negatives due to
insufficient log history being examined.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

Author: chmouel

test/gitea_test.go

@@ -161,7 +161,7 @@ func TestGiteaPullRequestPrivateRepository(t *testing.T) {
 	ctx, f := tgitea.TestPR(t, topts)
 	defer f()
 	reg := regexp.MustCompile(".*successfully fetched git-clone task from default configured catalog Hub")
-	maxLines := int64(100)
+	maxLines := int64(1000)
 	err := twait.RegexpMatchingInControllerLog(ctx, topts.ParamsRun, *reg, 20, "controller", &maxLines)
 	assert.NilError(t, err)
 	tgitea.WaitForSecretDeletion(t, topts, topts.TargetRefName)
@@ -252,7 +252,7 @@ func TestGiteaBadYamlValidation(t *testing.T) {
 
 	ctx, f := tgitea.TestPR(t, topts)
 	defer f()
-	maxLines := int64(20)
+	maxLines := int64(1000)
 	assert.NilError(t, twait.RegexpMatchingInControllerLog(ctx, topts.ParamsRun, *regexp.MustCompile(
 		"cannot read the PipelineRun: pr-bad-format.yaml, error: yaml validation error: line 3: could not find expected ':'"),
 		10, "controller", &maxLines))
@@ -998,7 +998,7 @@ func TestGiteaBadLinkOfTask(t *testing.T) {
 	ctx, f := tgitea.TestPR(t, topts)
 	defer f()
 	errre := regexp.MustCompile("There was an error starting the PipelineRun")
-	maxLines := int64(20)
+	maxLines := int64(1000)
 	assert.NilError(t, twait.RegexpMatchingInControllerLog(ctx, topts.ParamsRun, *errre, 10, "controller", &maxLines))
 }
 
@@ -1019,7 +1019,7 @@ func TestGiteaPipelineRunWithSameName(t *testing.T) {
 	ctx, f := tgitea.TestPR(t, topts)
 	defer f()
 	errre := regexp.MustCompile("found multiple pipelinerun in .tekton with the same name")
-	maxLines := int64(20)
+	maxLines := int64(1000)
 	assert.NilError(t, twait.RegexpMatchingInControllerLog(ctx, topts.ParamsRun, *errre, 10, "controller", &maxLines))
 }
 

test/github_pullrequest_privaterepository_test.go

@@ -28,7 +28,7 @@ func TestGithubPullRequestGitClone(t *testing.T) {
 	ctx, err := cctx.GetControllerCtxInfo(ctx, g.Cnx)
 	assert.NilError(t, err)
 
-	maxLines := int64(50)
+	maxLines := int64(1000)
 	assert.NilError(t, wait.RegexpMatchingInControllerLog(ctx, g.Cnx, *regexp.MustCompile(".*fetched git-clone task"),
 		10, "controller", &maxLines), "Error while checking the logs of the pipelines-as-code controller pod")
 	defer g.TearDown(ctx, t)

test/github_pullrequest_test.go

@@ -683,7 +683,7 @@ func TestGithubPullandPushMatchTriggerOnlyPull(t *testing.T) {
 	ctx = info.StoreNS(ctx, globalNs)
 
 	reg := regexp.MustCompile(fmt.Sprintf("Skipping push event for commit.*as it belongs to pull request #%d", g.PRNumber))
-	maxLines := int64(100)
+	maxLines := int64(1000)
 	err = twait.RegexpMatchingInControllerLog(ctx, g.Cnx, *reg, 20, "controller", &maxLines)
 	assert.NilError(t, err)
 }
@@ -743,7 +743,7 @@ func TestGithubIgnoreTagPushCommitsFromSkipPushEventsSetting(t *testing.T) {
 	ctx = info.StoreNS(ctx, globalNs)
 
 	reg := regexp.MustCompile(fmt.Sprintf("Processing tag push event for commit %s despite skip-push-events-for-pr-commits being enabled.*", g.SHA))
-	maxLines := int64(100)
+	maxLines := int64(1000)
 	err = twait.RegexpMatchingInControllerLog(ctx, g.Cnx, *reg, 20, "controller", &maxLines)
 	assert.NilError(t, err)
 

test/github_push_retest_test.go

@@ -192,7 +192,7 @@ func TestGithubPushRequestGitOpsCommentCancel(t *testing.T) {
 
 	// this went too fast so at least we check it was requested for it
 	if !cancelled {
-		numLines := int64(20)
+		numLines := int64(1000)
 		reg := regexp.MustCompile(".*pipelinerun.*skipping cancelling pipelinerun.*on-push.*already done.*")
 		err = twait.RegexpMatchingInControllerLog(ctx, g.Cnx, *reg, 10, "controller", &numLines)
 		if err != nil {

test/github_skip_ci_test.go

@@ -38,7 +38,7 @@ func verifySkipCI(ctx context.Context, t *testing.T, g *tgithub.PRTest, eventTyp
 	assert.NilError(t, err)
 
 	// Verify controller logs mention skip command detection
-	numLines := int64(100)
+	numLines := int64(1000)
 	skipLogRegex := regexp.MustCompile(fmt.Sprintf("CI skipped for %s event.*contains skip command in message", eventType))
 	err = twait.RegexpMatchingInControllerLog(ctx, g.Cnx, *skipLogRegex, 10, "controller", &numLines)
 	assert.NilError(t, err, "Expected controller logs to mention CI skip due to skip command")
@@ -106,7 +106,7 @@ func TestGithubSkipCITestCommand(t *testing.T) {
 	assert.NilError(t, err)
 
 	// Verify controller logs mention skip command detection
-	numLines := int64(100)
+	numLines := int64(1000)
 	skipLogRegex := regexp.MustCompile("CI skipped for pull request event.*contains skip command in message")
 	err = twait.RegexpMatchingInControllerLog(ctx, g.Cnx, *skipLogRegex, 10, "controller", &numLines)
 	assert.NilError(t, err, "Expected controller logs to mention CI skip due to skip command")

test/gitlab_delete_tag_event_test.go

@@ -46,7 +46,7 @@ func TestGitlabDeleteTagEvent(t *testing.T) {
 	assert.NilError(t, err)
 	runcnx.Clients.Log.Infof("Deleted Tag %s in %s repository", tagName, projectinfo.Name)
 
-	logLinesToCheck := int64(100)
+	logLinesToCheck := int64(1000)
 	reg := regexp.MustCompile("event Delete Tag Push Hook is not supported*")
 	err = twait.RegexpMatchingInControllerLog(ctx, runcnx, *reg, 10, "controller", &logLinesToCheck)
 	assert.NilError(t, err)

test/invalid_event_test.go

@@ -14,7 +14,7 @@ import (
 	"gotest.tools/v3/assert"
 )
 
-func TestUnsupportedEvent(t *testing.T) {
+func TestOthersUnsupportedEvent(t *testing.T) {
 	ctx := context.TODO()
 
 	event := github.ReleaseEvent{}
@@ -48,7 +48,7 @@ func TestUnsupportedEvent(t *testing.T) {
 	assert.Equal(t, resp.StatusCode, http.StatusOK, "%s reply expected 200 OK", elURL)
 }
 
-func TestSkippedEvent(t *testing.T) {
+func TestOthersSkippedEvent(t *testing.T) {
 	ctx := context.TODO()
 
 	event := github.PullRequestEvent{
@@ -84,7 +84,7 @@ func TestSkippedEvent(t *testing.T) {
 	assert.Assert(t, resp.StatusCode >= 200 && resp.StatusCode < 300, "%s reply expected 2xx OK: %d", elURL, resp.StatusCode)
 }
 
-func TestGETCall(t *testing.T) {
+func TestOthersGETCall(t *testing.T) {
 	ctx := context.TODO()
 
 	elURL := os.Getenv("TEST_EL_URL")

test/repo_validation_test.go

@@ -14,7 +14,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
-func TestRepoValidation(t *testing.T) {
+func TestOthersRepoValidation(t *testing.T) {
 	ctx := context.TODO()
 	run := params.New()
 	assert.NilError(t, run.Clients.NewClients(ctx, &run.Info))

test/repository_webhook_test.go

@@ -13,7 +13,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
-func TestRepositoryCreation(t *testing.T) {
+func TestOthersRepositoryCreation(t *testing.T) {
 	ctx := context.TODO()
 	ctx, runcnx, _, _, err := ghtest.Setup(ctx, false, false)
 	assert.NilError(t, err)