fix(labels): use positive check for InstallationID

theakshaypant · theakshaypant · commit 59a480c4041b · 2026-02-25T14:36:07.000+05:30
Change InstallationID validation from != -1 to &gt; 0 for better
semantic correctness.

Signed-off-by: Akshay Pant &lt;akshay.akshaypant@gmail.com&gt;
diff --git a/pkg/kubeinteraction/labels.go b/pkg/kubeinteraction/labels.go
@@ -66,7 +66,7 @@ func AddLabelsAndAnnotations(event *info.Event, pipelineRun *tektonv1.PipelineRu
 
 	// TODO: move to provider specific function
 	if providerConfig.Name == "github" || providerConfig.Name == "github-enterprise" {
-		if event.InstallationID != -1 {
+		if event.InstallationID > 0 {
 			annotations[keys.InstallationID] = strconv.FormatInt(event.InstallationID, 10)
 		}
 		if event.GHEURL != "" {

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ func AddLabelsAndAnnotations(event info.Event, pipelineRun tektonv1.PipelineRu`
`66`	`66`
`67`	`67`	`// TODO: move to provider specific function`
`68`	`68`	`if providerConfig.Name == "github" \|\| providerConfig.Name == "github-enterprise" {`
`69`		`- if event.InstallationID != -1 {`
	`69`	`+ if event.InstallationID > 0 {`
`70`	`70`	`annotations[keys.InstallationID] = strconv.FormatInt(event.InstallationID, 10)`
`71`	`71`	`}`
`72`	`72`	`if event.GHEURL != "" {`